forked from jstedfast/MimeKit
-
Notifications
You must be signed in to change notification settings - Fork 0
/
disposable.patch
1997 lines (1857 loc) · 62.9 KB
/
disposable.patch
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
871
872
873
874
875
876
877
878
879
880
881
882
883
884
885
886
887
888
889
890
891
892
893
894
895
896
897
898
899
900
901
902
903
904
905
906
907
908
909
910
911
912
913
914
915
916
917
918
919
920
921
922
923
924
925
926
927
928
929
930
931
932
933
934
935
936
937
938
939
940
941
942
943
944
945
946
947
948
949
950
951
952
953
954
955
956
957
958
959
960
961
962
963
964
965
966
967
968
969
970
971
972
973
974
975
976
977
978
979
980
981
982
983
984
985
986
987
988
989
990
991
992
993
994
995
996
997
998
999
1000
diff --git a/MimeKit/AttachmentCollection.cs b/MimeKit/AttachmentCollection.cs
index 30e0b93..5303fa5 100644
--- a/MimeKit/AttachmentCollection.cs
+++ b/MimeKit/AttachmentCollection.cs
@@ -472,6 +472,9 @@ namespace MimeKit {
/// </remarks>
public void Clear ()
{
+ for (int i = 0; i < attachments.Count; i++)
+ attachments[i].Dispose ();
+
attachments.Clear ();
}
@@ -599,6 +602,7 @@ namespace MimeKit {
if (index < 0 || index > Count)
throw new ArgumentOutOfRangeException ("index");
+ attachments[index].Dispose ();
attachments.RemoveAt (index);
}
diff --git a/MimeKit/ContentObject.cs b/MimeKit/ContentObject.cs
index 936e059..d8c32b1 100644
--- a/MimeKit/ContentObject.cs
+++ b/MimeKit/ContentObject.cs
@@ -41,7 +41,7 @@ namespace MimeKit {
/// </remarks>
public class ContentObject : IContentObject
{
- readonly Stream content;
+ Stream content;
/// <summary>
/// Initializes a new instance of the <see cref="MimeKit.ContentObject"/> class.
@@ -76,7 +76,24 @@ namespace MimeKit {
content = stream;
}
- #region IContentObject implementation
+ /// <summary>
+ /// Releases unmanaged resources and performs other cleanup operations before the
+ /// <see cref="MimeKit.ContentObject"/> is reclaimed by garbage collection.
+ /// </summary>
+ /// <remarks>
+ /// Releases unmanaged resources and performs other cleanup operations before the
+ /// <see cref="MimeKit.ContentObject"/> is reclaimed by garbage collection.
+ /// </remarks>
+ ~ContentObject ()
+ {
+ Dispose (false);
+ }
+
+ void CheckDisposed ()
+ {
+ if (content == null)
+ throw new ObjectDisposedException ("ContentObject");
+ }
/// <summary>
/// Gets or sets the content encoding.
@@ -99,8 +116,13 @@ namespace MimeKit {
/// stream using <see cref="DecodeTo(System.IO.Stream,System.Threading.CancellationToken)"/>.
/// </remarks>
/// <returns>The decoded content stream.</returns>
+ /// <exception cref="System.ObjectDisposedException">
+ /// The <see cref="ContentObject"/> has been disposed.
+ /// </exception>
public Stream Open ()
{
+ CheckDisposed ();
+
content.Seek (0, SeekOrigin.Begin);
var filtered = new FilteredStream (content);
@@ -122,6 +144,9 @@ namespace MimeKit {
/// <exception cref="System.ArgumentNullException">
/// <paramref name="stream"/> is <c>null</c>.
/// </exception>
+ /// <exception cref="System.ObjectDisposedException">
+ /// The <see cref="ContentObject"/> has been disposed.
+ /// </exception>
/// <exception cref="System.OperationCanceledException">
/// The operation was canceled via the cancellation token.
/// </exception>
@@ -133,6 +158,8 @@ namespace MimeKit {
if (stream == null)
throw new ArgumentNullException ("stream");
+ CheckDisposed ();
+
var readable = content as ICancellableStream;
var writable = stream as ICancellableStream;
var buf = new byte[4096];
@@ -182,6 +209,9 @@ namespace MimeKit {
/// <exception cref="System.ArgumentNullException">
/// <paramref name="stream"/> is <c>null</c>.
/// </exception>
+ /// <exception cref="System.ObjectDisposedException">
+ /// The <see cref="ContentObject"/> has been disposed.
+ /// </exception>
/// <exception cref="System.OperationCanceledException">
/// The operation was canceled via the cancellation token.
/// </exception>
@@ -193,6 +223,8 @@ namespace MimeKit {
if (stream == null)
throw new ArgumentNullException ("stream");
+ CheckDisposed ();
+
using (var filtered = new FilteredStream (stream)) {
filtered.Add (DecoderFilter.Create (Encoding));
WriteTo (filtered, cancellationToken);
@@ -200,6 +232,35 @@ namespace MimeKit {
}
}
- #endregion
+ /// <summary>
+ /// Releases the unmanaged resources used by the <see cref="ContentObject"/> and
+ /// optionally releases the managed resources.
+ /// </summary>
+ /// <remarks>
+ /// Releases the unmanaged resources used by the <see cref="ContentObject"/> and
+ /// optionally releases the managed resources.
+ /// </remarks>
+ /// <param name="disposing"><c>true</c> to release both managed and unmanaged resources;
+ /// <c>false</c> to release only the unmanaged resources.</param>
+ protected virtual void Dispose (bool disposing)
+ {
+ if (disposing && content != null) {
+ content.Dispose ();
+ content = null;
+ }
+ }
+
+ /// <summary>
+ /// Releases all resources used by the <see cref="MimeKit.ContentObject"/> object.
+ /// </summary>
+ /// <remarks>Call <see cref="Dispose()"/> when you are finished using the <see cref="MimeKit.ContentObject"/>. The
+ /// <see cref="Dispose()"/> method leaves the <see cref="MimeKit.ContentObject"/> in an unusable state. After
+ /// calling <see cref="Dispose()"/>, you must release all references to the <see cref="MimeKit.ContentObject"/> so
+ /// the garbage collector can reclaim the memory that the <see cref="MimeKit.ContentObject"/> was occupying.</remarks>
+ public void Dispose ()
+ {
+ Dispose (true);
+ GC.SuppressFinalize (this);
+ }
}
}
diff --git a/MimeKit/Cryptography/ApplicationPgpEncrypted.cs b/MimeKit/Cryptography/ApplicationPgpEncrypted.cs
index 29c8605..9dfcd98 100644
--- a/MimeKit/Cryptography/ApplicationPgpEncrypted.cs
+++ b/MimeKit/Cryptography/ApplicationPgpEncrypted.cs
@@ -71,6 +71,12 @@ namespace MimeKit.Cryptography {
ContentObject = new ContentObject (content);
}
+ void CheckDisposed ()
+ {
+ if (IsDisposed)
+ throw new ObjectDisposedException ("ApplicationPgpEncrypted");
+ }
+
/// <summary>
/// Dispatches to the specific visit method for this MIME entity.
/// </summary>
@@ -86,11 +92,16 @@ namespace MimeKit.Cryptography {
/// <exception cref="System.ArgumentNullException">
/// <paramref name="visitor"/> is <c>null</c>.
/// </exception>
+ /// <exception cref="System.ObjectDisposedException">
+ /// The object has been disposed.
+ /// </exception>
public override void Accept (MimeVisitor visitor)
{
if (visitor == null)
throw new ArgumentNullException ("visitor");
+ CheckDisposed ();
+
visitor.VisitApplicationPgpEncrypted (this);
}
}
diff --git a/MimeKit/Cryptography/ApplicationPgpSignature.cs b/MimeKit/Cryptography/ApplicationPgpSignature.cs
index ea81d0f..5a00f39 100644
--- a/MimeKit/Cryptography/ApplicationPgpSignature.cs
+++ b/MimeKit/Cryptography/ApplicationPgpSignature.cs
@@ -78,6 +78,12 @@ namespace MimeKit.Cryptography {
ContentObject = new ContentObject (stream);
}
+ void CheckDisposed ()
+ {
+ if (IsDisposed)
+ throw new ObjectDisposedException ("ApplicationPgpSignature");
+ }
+
/// <summary>
/// Dispatches to the specific visit method for this MIME entity.
/// </summary>
@@ -93,11 +99,16 @@ namespace MimeKit.Cryptography {
/// <exception cref="System.ArgumentNullException">
/// <paramref name="visitor"/> is <c>null</c>.
/// </exception>
+ /// <exception cref="System.ObjectDisposedException">
+ /// The object has been disposed.
+ /// </exception>
public override void Accept (MimeVisitor visitor)
{
if (visitor == null)
throw new ArgumentNullException ("visitor");
+ CheckDisposed ();
+
visitor.VisitApplicationPgpSignature (this);
}
}
diff --git a/MimeKit/Cryptography/ApplicationPkcs7Mime.cs b/MimeKit/Cryptography/ApplicationPkcs7Mime.cs
index c5efaef..99f1dba 100644
--- a/MimeKit/Cryptography/ApplicationPkcs7Mime.cs
+++ b/MimeKit/Cryptography/ApplicationPkcs7Mime.cs
@@ -111,6 +111,12 @@ namespace MimeKit.Cryptography {
}
}
+ void CheckDisposed ()
+ {
+ if (IsDisposed)
+ throw new ObjectDisposedException ("ApplicationPkcs7Mime");
+ }
+
/// <summary>
/// Gets the value of the "smime-type" parameter.
/// </summary>
@@ -150,11 +156,16 @@ namespace MimeKit.Cryptography {
/// <exception cref="System.ArgumentNullException">
/// <paramref name="visitor"/> is <c>null</c>.
/// </exception>
+ /// <exception cref="System.ObjectDisposedException">
+ /// The object has been disposed.
+ /// </exception>
public override void Accept (MimeVisitor visitor)
{
if (visitor == null)
throw new ArgumentNullException ("visitor");
+ CheckDisposed ();
+
visitor.VisitApplicationPkcs7Mime (this);
}
@@ -169,6 +180,9 @@ namespace MimeKit.Cryptography {
/// <exception cref="System.ArgumentNullException">
/// <paramref name="ctx"/> is <c>null</c>.
/// </exception>
+ /// <exception cref="System.ObjectDisposedException">
+ /// The object has been disposed.
+ /// </exception>
/// <exception cref="System.InvalidOperationException">
/// The "smime-type" parameter on the Content-Type header is not "compressed-data".
/// </exception>
@@ -180,6 +194,8 @@ namespace MimeKit.Cryptography {
if (ctx == null)
throw new ArgumentNullException ("ctx");
+ CheckDisposed ();
+
if (SecureMimeType != SecureMimeType.CompressedData)
throw new InvalidOperationException ();
@@ -198,6 +214,9 @@ namespace MimeKit.Cryptography {
/// Decompresses the content using the default <see cref="SecureMimeContext"/>.
/// </remarks>
/// <returns>The decompressed <see cref="MimeKit.MimeEntity"/>.</returns>
+ /// <exception cref="System.ObjectDisposedException">
+ /// The object has been disposed.
+ /// </exception>
/// <exception cref="System.InvalidOperationException">
/// The "smime-type" parameter on the Content-Type header is not "compressed-data".
/// </exception>
@@ -225,6 +244,9 @@ namespace MimeKit.Cryptography {
/// <exception cref="System.ArgumentNullException">
/// <paramref name="ctx"/> is <c>null</c>.
/// </exception>
+ /// <exception cref="System.ObjectDisposedException">
+ /// The object has been disposed.
+ /// </exception>
/// <exception cref="System.InvalidOperationException">
/// The "smime-type" parameter on the Content-Type header is not "enveloped-data".
/// </exception>
@@ -236,6 +258,8 @@ namespace MimeKit.Cryptography {
if (ctx == null)
throw new ArgumentNullException ("ctx");
+ CheckDisposed ();
+
if (SecureMimeType != SecureMimeType.EnvelopedData)
throw new InvalidOperationException ();
@@ -254,6 +278,9 @@ namespace MimeKit.Cryptography {
/// Decrypts the content using the default <see cref="SecureMimeContext"/>.
/// </remarks>
/// <returns>The decrypted <see cref="MimeKit.MimeEntity"/>.</returns>
+ /// <exception cref="System.ObjectDisposedException">
+ /// The object has been disposed.
+ /// </exception>
/// <exception cref="System.InvalidOperationException">
/// The "smime-type" parameter on the Content-Type header is not "certs-only".
/// </exception>
@@ -277,6 +304,9 @@ namespace MimeKit.Cryptography {
/// <exception cref="System.ArgumentNullException">
/// <paramref name="ctx"/> is <c>null</c>.
/// </exception>
+ /// <exception cref="System.ObjectDisposedException">
+ /// The object has been disposed.
+ /// </exception>
/// <exception cref="System.InvalidOperationException">
/// The "smime-type" parameter on the Content-Type header is not "certs-only".
/// </exception>
@@ -288,6 +318,8 @@ namespace MimeKit.Cryptography {
if (ctx == null)
throw new ArgumentNullException ("ctx");
+ CheckDisposed ();
+
if (SecureMimeType != SecureMimeType.CertsOnly)
throw new InvalidOperationException ();
@@ -311,6 +343,9 @@ namespace MimeKit.Cryptography {
/// <exception cref="System.ArgumentNullException">
/// <paramref name="ctx"/> is <c>null</c>.
/// </exception>
+ /// <exception cref="System.ObjectDisposedException">
+ /// The object has been disposed.
+ /// </exception>
/// <exception cref="System.InvalidOperationException">
/// The "smime-type" parameter on the Content-Type header is not "signed-data".
/// </exception>
@@ -322,6 +357,8 @@ namespace MimeKit.Cryptography {
if (ctx == null)
throw new ArgumentNullException ("ctx");
+ CheckDisposed ();
+
if (SecureMimeType != SecureMimeType.SignedData)
throw new InvalidOperationException ();
@@ -341,6 +378,9 @@ namespace MimeKit.Cryptography {
/// </remarks>
/// <returns>The list of digital signatures.</returns>
/// <param name="entity">The unencapsulated entity.</param>
+ /// <exception cref="System.ObjectDisposedException">
+ /// The object has been disposed.
+ /// </exception>
/// <exception cref="System.InvalidOperationException">
/// The "smime-type" parameter on the Content-Type header is not "signed-data".
/// </exception>
diff --git a/MimeKit/Cryptography/ApplicationPkcs7Signature.cs b/MimeKit/Cryptography/ApplicationPkcs7Signature.cs
index d721ee0..eb46450 100644
--- a/MimeKit/Cryptography/ApplicationPkcs7Signature.cs
+++ b/MimeKit/Cryptography/ApplicationPkcs7Signature.cs
@@ -92,11 +92,17 @@ namespace MimeKit.Cryptography {
/// <exception cref="System.ArgumentNullException">
/// <paramref name="visitor"/> is <c>null</c>.
/// </exception>
+ /// <exception cref="System.ObjectDisposedException">
+ /// The object has been disposed.
+ /// </exception>
public override void Accept (MimeVisitor visitor)
{
if (visitor == null)
throw new ArgumentNullException ("visitor");
+ if (IsDisposed)
+ throw new ObjectDisposedException ("ApplicationPkcs7Signature");
+
visitor.VisitApplicationPkcs7Signature (this);
}
}
diff --git a/MimeKit/Cryptography/MultipartEncrypted.cs b/MimeKit/Cryptography/MultipartEncrypted.cs
index dde049a..c7e7025 100644
--- a/MimeKit/Cryptography/MultipartEncrypted.cs
+++ b/MimeKit/Cryptography/MultipartEncrypted.cs
@@ -65,6 +65,12 @@ namespace MimeKit.Cryptography {
{
}
+ void CheckDisposed ()
+ {
+ if (IsDisposed)
+ throw new ObjectDisposedException ("MultipartEncrypted");
+ }
+
/// <summary>
/// Dispatches to the specific visit method for this MIME entity.
/// </summary>
@@ -80,11 +86,16 @@ namespace MimeKit.Cryptography {
/// <exception cref="System.ArgumentNullException">
/// <paramref name="visitor"/> is <c>null</c>.
/// </exception>
+ /// <exception cref="System.ObjectDisposedException">
+ /// The object has been disposed.
+ /// </exception>
public override void Accept (MimeVisitor visitor)
{
if (visitor == null)
throw new ArgumentNullException ("visitor");
+ CheckDisposed ();
+
visitor.VisitMultipartEncrypted (this);
}
@@ -607,8 +618,13 @@ namespace MimeKit.Cryptography {
// add the protocol version part
encrypted.Add (new ApplicationPgpEncrypted ());
- // add the encrypted entity as the second part
- encrypted.Add (ctx.SignAndEncrypt (signer, digestAlgo, recipients, memory));
+ try {
+ // add the encrypted entity as the second part
+ encrypted.Add (ctx.SignAndEncrypt (signer, digestAlgo, recipients, memory));
+ } catch {
+ encrypted.Dispose ();
+ throw;
+ }
return encrypted;
}
@@ -737,8 +753,13 @@ namespace MimeKit.Cryptography {
// add the protocol version part
encrypted.Add (new ApplicationPgpEncrypted ());
- // add the encrypted entity as the second part
- encrypted.Add (ctx.SignAndEncrypt (signer, digestAlgo, cipherAlgo, recipients, memory));
+ try {
+ // add the encrypted entity as the second part
+ encrypted.Add (ctx.SignAndEncrypt (signer, digestAlgo, cipherAlgo, recipients, memory));
+ } catch {
+ encrypted.Dispose ();
+ throw;
+ }
return encrypted;
}
@@ -813,8 +834,13 @@ namespace MimeKit.Cryptography {
// add the protocol version part
encrypted.Add (new ApplicationPgpEncrypted ());
- // add the encrypted entity as the second part
- encrypted.Add (ctx.SignAndEncrypt (signer, digestAlgo, recipients, memory));
+ try {
+ // add the encrypted entity as the second part
+ encrypted.Add (ctx.SignAndEncrypt (signer, digestAlgo, recipients, memory));
+ } catch {
+ encrypted.Dispose ();
+ throw;
+ }
return encrypted;
}
@@ -986,8 +1012,13 @@ namespace MimeKit.Cryptography {
// add the protocol version part
encrypted.Add (new ApplicationPgpEncrypted ());
- // add the encrypted entity as the second part
- encrypted.Add (ctx.Encrypt (recipients, memory));
+ try {
+ // add the encrypted entity as the second part
+ encrypted.Add (ctx.Encrypt (recipients, memory));
+ } catch {
+ encrypted.Dispose ();
+ throw;
+ }
return encrypted;
}
@@ -1081,8 +1112,13 @@ namespace MimeKit.Cryptography {
// add the protocol version part
encrypted.Add (new ApplicationPgpEncrypted ());
- // add the encrypted entity as the second part
- encrypted.Add (ctx.Encrypt (algorithm, recipients, memory));
+ try {
+ // add the encrypted entity as the second part
+ encrypted.Add (ctx.Encrypt (algorithm, recipients, memory));
+ } catch {
+ encrypted.Dispose ();
+ throw;
+ }
return encrypted;
}
@@ -1137,8 +1173,13 @@ namespace MimeKit.Cryptography {
// add the protocol version part
encrypted.Add (new ApplicationPgpEncrypted ());
- // add the encrypted entity as the second part
- encrypted.Add (ctx.Encrypt (recipients, memory));
+ try {
+ // add the encrypted entity as the second part
+ encrypted.Add (ctx.Encrypt (recipients, memory));
+ } catch {
+ encrypted.Dispose ();
+ throw;
+ }
return encrypted;
}
@@ -1230,6 +1271,9 @@ namespace MimeKit.Cryptography {
/// <exception cref="System.ArgumentNullException">
/// <paramref name="ctx"/> is <c>null</c>.
/// </exception>
+ /// <exception cref="System.ObjectDisposedException">
+ /// The object has been disposed.
+ /// </exception>
/// <exception cref="System.FormatException">
/// <para>The <c>protocol</c> parameter was not specified.</para>
/// <para>-or-</para>
@@ -1252,6 +1296,8 @@ namespace MimeKit.Cryptography {
if (ctx == null)
throw new ArgumentNullException ("ctx");
+ CheckDisposed ();
+
var protocol = ContentType.Parameters["protocol"];
if (string.IsNullOrEmpty (protocol))
throw new FormatException ();
@@ -1298,6 +1344,9 @@ namespace MimeKit.Cryptography {
/// <exception cref="System.ArgumentNullException">
/// <paramref name="ctx"/> is <c>null</c>.
/// </exception>
+ /// <exception cref="System.ObjectDisposedException">
+ /// The object has been disposed.
+ /// </exception>
/// <exception cref="System.FormatException">
/// <para>The <c>protocol</c> parameter was not specified.</para>
/// <para>-or-</para>
@@ -1331,6 +1380,9 @@ namespace MimeKit.Cryptography {
/// </remarks>
/// <returns>The decrypted entity.</returns>
/// <param name="signatures">A list of digital signatures if the data was both signed and encrypted.</param>
+ /// <exception cref="System.ObjectDisposedException">
+ /// The object has been disposed.
+ /// </exception>
/// <exception cref="System.FormatException">
/// <para>The <c>protocol</c> parameter was not specified.</para>
/// <para>-or-</para>
@@ -1351,6 +1403,8 @@ namespace MimeKit.Cryptography {
/// </exception>
public MimeEntity Decrypt (out DigitalSignatureCollection signatures)
{
+ CheckDisposed ();
+
var protocol = ContentType.Parameters["protocol"];
if (string.IsNullOrEmpty (protocol))
throw new FormatException ();
@@ -1400,6 +1454,9 @@ namespace MimeKit.Cryptography {
/// Decrypts the <see cref="MultipartEncrypted"/> part.
/// </remarks>
/// <returns>The decrypted entity.</returns>
+ /// <exception cref="System.ObjectDisposedException">
+ /// The object has been disposed.
+ /// </exception>
/// <exception cref="System.FormatException">
/// <para>The <c>protocol</c> parameter was not specified.</para>
/// <para>-or-</para>
diff --git a/MimeKit/Cryptography/MultipartSigned.cs b/MimeKit/Cryptography/MultipartSigned.cs
index 73c013d..7a43d4c 100644
--- a/MimeKit/Cryptography/MultipartSigned.cs
+++ b/MimeKit/Cryptography/MultipartSigned.cs
@@ -64,6 +64,12 @@ namespace MimeKit.Cryptography {
{
}
+ void CheckDisposed ()
+ {
+ if (IsDisposed)
+ throw new ObjectDisposedException ("MultipartSigned");
+ }
+
/// <summary>
/// Dispatches to the specific visit method for this MIME entity.
/// </summary>
@@ -79,11 +85,16 @@ namespace MimeKit.Cryptography {
/// <exception cref="System.ArgumentNullException">
/// <paramref name="visitor"/> is <c>null</c>.
/// </exception>
+ /// <exception cref="System.ObjectDisposedException">
+ /// The object has been disposed.
+ /// </exception>
public override void Accept (MimeVisitor visitor)
{
if (visitor == null)
throw new ArgumentNullException ("visitor");
+ CheckDisposed ();
+
visitor.VisitMultipartSigned (this);
}
@@ -152,11 +163,20 @@ namespace MimeKit.Cryptography {
// Note: we need to parse the modified entity structure to preserve any modifications
var parser = new MimeParser (memory, MimeFormat.Entity);
var parsed = parser.ParseEntity ();
+ MimePart signature;
+
memory.Position = 0;
- // sign the cleartext content
- var signature = ctx.Sign (signer, digestAlgo, memory);
+ try {
+ // sign the cleartext content
+ signature = ctx.Sign (signer, digestAlgo, memory);
+ } catch {
+ parsed.Dispose ();
+ throw;
+ }
+
var micalg = ctx.GetDigestAlgorithmName (digestAlgo);
+
var signed = new MultipartSigned ();
// set the protocol and micalg Content-Type parameters
@@ -415,11 +435,16 @@ namespace MimeKit.Cryptography {
/// <para>-or-</para>
/// <para><paramref name="constraint"/> is not a valid value.</para>
/// </exception>
+ /// <exception cref="System.ObjectDisposedException">
+ /// The object has been disposed.
+ /// </exception>
public override void Prepare (EncodingConstraint constraint, int maxLineLength = 78)
{
if (maxLineLength < 72 || maxLineLength > 998)
throw new ArgumentOutOfRangeException ("maxLineLength");
+ CheckDisposed ();
+
// Note: we do not iterate over our children because they are already signed
// and changing them would break the signature. They should already be
// properly prepared, anyway.
@@ -436,6 +461,9 @@ namespace MimeKit.Cryptography {
/// <exception cref="System.ArgumentNullException">
/// <paramref name="ctx"/> is <c>null</c>.
/// </exception>
+ /// <exception cref="System.ObjectDisposedException">
+ /// The object has been disposed.
+ /// </exception>
/// <exception cref="System.FormatException">
/// The multipart is malformed in some way.
/// </exception>
@@ -450,6 +478,8 @@ namespace MimeKit.Cryptography {
if (ctx == null)
throw new ArgumentNullException ("ctx");
+ CheckDisposed ();
+
var protocol = ContentType.Parameters["protocol"];
if (string.IsNullOrEmpty (protocol))
throw new FormatException ("The multipart/signed part did not specify a protocol.");
@@ -493,6 +523,9 @@ namespace MimeKit.Cryptography {
/// Verifies the multipart/signed part using the default cryptography context.
/// </remarks>
/// <returns>A signer info collection.</returns>
+ /// <exception cref="System.ObjectDisposedException">
+ /// The object has been disposed.
+ /// </exception>
/// <exception cref="System.FormatException">
/// <para>The <c>protocol</c> parameter was not specified.</para>
/// <para>-or-</para>
@@ -506,6 +539,8 @@ namespace MimeKit.Cryptography {
/// </exception>
public DigitalSignatureCollection Verify ()
{
+ CheckDisposed ();
+
var protocol = ContentType.Parameters["protocol"];
if (string.IsNullOrEmpty (protocol))
throw new FormatException ("The multipart/signed part did not specify a protocol.");
diff --git a/MimeKit/IContentObject.cs b/MimeKit/IContentObject.cs
index 1203001..3b9f698 100644
--- a/MimeKit/IContentObject.cs
+++ b/MimeKit/IContentObject.cs
@@ -24,6 +24,7 @@
// THE SOFTWARE.
//
+using System;
using System.IO;
using System.Threading;
@@ -34,7 +35,7 @@ namespace MimeKit {
/// <remarks>
/// Implemented by <see cref="ContentObject"/>.
/// </remarks>
- public interface IContentObject
+ public interface IContentObject : IDisposable
{
/// <summary>
/// Gets the content encoding.
diff --git a/MimeKit/MessageDeliveryStatus.cs b/MimeKit/MessageDeliveryStatus.cs
index d3fbfae..800ec0a 100644
--- a/MimeKit/MessageDeliveryStatus.cs
+++ b/MimeKit/MessageDeliveryStatus.cs
@@ -64,6 +64,12 @@ namespace MimeKit {
{
}
+ void CheckDisposed ()
+ {
+ if (IsDisposed)
+ throw new ObjectDisposedException ("MessageDeliveryStatus");
+ }
+
/// <summary>
/// Get the groups of delivery status fields.
/// </summary>
@@ -127,11 +133,16 @@ namespace MimeKit {
/// <exception cref="System.ArgumentNullException">
/// <paramref name="visitor"/> is <c>null</c>.
/// </exception>
+ /// <exception cref="System.ObjectDisposedException">
+ /// The object has been disposed.
+ /// </exception>
public override void Accept (MimeVisitor visitor)
{
if (visitor == null)
throw new ArgumentNullException ("visitor");
+ CheckDisposed ();
+
visitor.VisitMessageDeliveryStatus (this);
}
}
diff --git a/MimeKit/MessageDispositionNotification.cs b/MimeKit/MessageDispositionNotification.cs
index 193d5d8..2b5e343 100644
--- a/MimeKit/MessageDispositionNotification.cs
+++ b/MimeKit/MessageDispositionNotification.cs
@@ -65,6 +65,12 @@ namespace MimeKit {
{
}
+ void CheckDisposed ()
+ {
+ if (IsDisposed)
+ throw new ObjectDisposedException ("MessageDispositionNotification");
+ }
+
/// <summary>
/// Get the disposition notification fields.
/// </summary>
@@ -117,11 +123,16 @@ namespace MimeKit {
/// <exception cref="System.ArgumentNullException">
/// <paramref name="visitor"/> is <c>null</c>.
/// </exception>
+ /// <exception cref="System.ObjectDisposedException">
+ /// The object has been disposed.
+ /// </exception>
public override void Accept (MimeVisitor visitor)
{
if (visitor == null)
throw new ArgumentNullException ("visitor");
+ CheckDisposed ();
+
visitor.VisitMessageDispositionNotification (this);
}
}
diff --git a/MimeKit/MessagePart.cs b/MimeKit/MessagePart.cs
index 9376b21..6bb743d 100644
--- a/MimeKit/MessagePart.cs
+++ b/MimeKit/MessagePart.cs
@@ -203,5 +203,23 @@ namespace MimeKit {
if (Message != null)
Message.WriteTo (options, stream, cancellationToken);
}
+
+ /// <summary>
+ /// Releases the unmanaged resources used by the <see cref="MessagePart"/> and
+ /// optionally releases the managed resources.
+ /// </summary>
+ /// <remarks>
+ /// Releases the unmanaged resources used by the <see cref="MessagePart"/> and
+ /// optionally releases the managed resources.
+ /// </remarks>
+ /// <param name="disposing"><c>true</c> to release both managed and unmanaged resources;
+ /// <c>false</c> to release only the unmanaged resources.</param>
+ protected override void Dispose (bool disposing)
+ {
+ if (disposing && !IsDisposed && Message != null)
+ Message.Dispose ();
+
+ base.Dispose (disposing);
+ }
}
}
diff --git a/MimeKit/MessagePartial.cs b/MimeKit/MessagePartial.cs
index 4c04c45..9c89128 100644
--- a/MimeKit/MessagePartial.cs
+++ b/MimeKit/MessagePartial.cs
@@ -96,6 +96,12 @@ namespace MimeKit {
ContentType.Parameters.Add (new Parameter ("total", total.ToString ()));
}
+ void CheckDisposed ()
+ {
+ if (IsDisposed)
+ throw new ObjectDisposedException ("MessagePartial");
+ }
+
/// <summary>
/// Gets the "id" parameter of the Content-Type header.
/// </summary>
@@ -165,6 +171,8 @@ namespace MimeKit {
if (visitor == null)
throw new ArgumentNullException ("visitor");
+ CheckDisposed ();
+
visitor.VisitMessagePartial (this);
}
diff --git a/MimeKit/MimeEntity.cs b/MimeKit/MimeEntity.cs
index b7d0a6c..fafd546 100644
--- a/MimeKit/MimeEntity.cs
+++ b/MimeKit/MimeEntity.cs
@@ -49,7 +49,7 @@ namespace MimeKit {
/// <see cref="MimePart"/> who's content is another MIME message/document). All other types are
/// derivatives of one of those.</para>
/// </remarks>
- public abstract class MimeEntity
+ public abstract class MimeEntity : IDisposable
{
ContentDisposition disposition;
string contentId;
@@ -129,6 +129,25 @@ namespace MimeKit {
}
/// <summary>
+ /// Releases unmanaged resources and performs other cleanup operations before the
+ /// <see cref="MimeKit.MimeEntity"/> is reclaimed by garbage collection.
+ /// </summary>
+ /// <remarks>
+ /// Releases unmanaged resources and performs other cleanup operations before the
+ /// <see cref="MimeKit.MimeEntity"/> is reclaimed by garbage collection.
+ /// </remarks>
+ ~MimeEntity ()
+ {
+ Dispose (false);
+ }
+
+ void CheckDisposed ()
+ {
+ if (IsDisposed)
+ throw new ObjectDisposedException ("MimeEntity");
+ }
+
+ /// <summary>
/// Tries to use the given object to initialize the appropriate property.
/// </summary>
/// <remarks>
@@ -156,6 +175,17 @@ namespace MimeKit {
}
/// <summary>
+ /// Gets a value indicating whether the entity has been disposed.
+ /// </summary>
+ /// <remarks>
+ /// Gets a value indicating whether the entity has been disposed.
+ /// </remarks>
+ /// <value><c>true</c> if the entity has been disposed; otherwise, <c>false</c>.</value>
+ protected bool IsDisposed {
+ get; private set;
+ }
+
+ /// <summary>
/// Gets the list of headers.
/// </summary>
/// <remarks>
@@ -177,9 +207,14 @@ namespace MimeKit {
/// be <c>null</c>.
/// </remarks>
/// <value>The content disposition.</value>
+ /// <exception cref="System.ObjectDisposedException">
+ /// The object has been disposed.
+ /// </exception>
public ContentDisposition ContentDisposition {
get { return disposition; }
set {
+ CheckDisposed ();
+
if (disposition == value)
return;
@@ -221,9 +256,14 @@ namespace MimeKit {
/// <exception cref="System.ArgumentException">
/// <paramref name="value"/> is not an absolute URI.
/// </exception>
+ /// <exception cref="System.ObjectDisposedException">
+ /// The object has been disposed.
+ /// </exception>
public Uri ContentBase {
get { return baseUri; }
set {
+ CheckDisposed ();
+
if (baseUri == value)
return;
@@ -252,9 +292,14 @@ namespace MimeKit {
/// <para>For more information, see http://www.ietf.org/rfc/rfc2110.txt</para>
/// </remarks>
/// <value>The content location or <c>null</c>.</value>
+ /// <exception cref="System.ObjectDisposedException">
+ /// The object has been disposed.
+ /// </exception>
public Uri ContentLocation {
get { return location; }
set {
+ CheckDisposed ();
+
if (location == value)
return;
@@ -279,9 +324,14 @@ namespace MimeKit {
/// when the HTML-formatted message body needs to reference image attachments.</para>
/// </remarks>
/// <value>The content identifier.</value>
+ /// <exception cref="System.ObjectDisposedException">
+ /// The object has been disposed.
+ /// </exception>
public string ContentId {
get { return contentId; }
set {
+ CheckDisposed ();
+
if (contentId == value)
return;
@@ -313,9 +363,14 @@ namespace MimeKit {
/// <see cref="MimePart"/> is not meant to be treated as an attachment.
/// </remarks>
/// <value><c>true</c> if this <see cref="MimePart"/> is an attachment; otherwise, <c>false</c>.</value>
+ /// <exception cref="System.ObjectDisposedException">
+ /// The object has been disposed.
+ /// </exception>
public bool IsAttachment {
get { return ContentDisposition != null && ContentDisposition.IsAttachment; }
set {
+ CheckDisposed ();
+
if (value) {
if (ContentDisposition == null)
ContentDisposition = new ContentDisposition (ContentDisposition.Attachment);
@@ -334,8 +389,13 @@ namespace MimeKit {
/// Returns a <see cref="System.String"/> that represents the current <see cref="MimeKit.MimeEntity"/>.
/// </remarks>
/// <returns>A <see cref="System.String"/> that represents the current <see cref="MimeKit.MimeEntity"/>.</returns>
+ /// <exception cref="System.ObjectDisposedException">
+ /// The object has been disposed.
+ /// </exception>
public override string ToString ()
{
+ CheckDisposed ();
+
using (var memory = new MemoryStream ()) {
WriteTo (memory);
@@ -365,11 +425,16 @@ namespace MimeKit {
/// <exception cref="System.ArgumentNullException">
/// <paramref name="visitor"/> is <c>null</c>.
/// </exception>
+ /// <exception cref="System.ObjectDisposedException">
+ /// The object has been disposed.
+ /// </exception>
public virtual void Accept (MimeVisitor visitor)
{
if (visitor == null)
throw new ArgumentNullException ("visitor");
+ CheckDisposed ();
+
visitor.VisitMimeEntity (this);
}
@@ -386,6 +451,9 @@ namespace MimeKit {
/// <para>-or-</para>
/// <para><paramref name="constraint"/> is not a valid value.</para>
/// </exception>
+ /// <exception cref="System.ObjectDisposedException">
+ /// The object has been disposed.
+ /// </exception>
public abstract void Prepare (EncodingConstraint constraint, int maxLineLength = 78);
/// <summary>
@@ -403,6 +471,9 @@ namespace MimeKit {
/// <para>-or-</para>
/// <para><paramref name="stream"/> is <c>null</c>.</para>
/// </exception>