You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
If I understand correctly, this was made to validate URL withtout :// (which is mandatory in django URLValidator).
It create an issue with the regex being different between django version. As it is use directly as validator, it create diff in django migration when changing python version.
In order to ensure stable behavior with multiple version of django, this part has been removed as a quick solution. dd5b08a
One of the solution could be to create a CustomURLValidator from URLValidator and override the __call__ method to only validate the url and skip the scheme validation part.
On the
PostgisSource
model, the fielddb_host
is using a custom regex as validator build withURLValidator
If I understand correctly, this was made to validate URL withtout
://
(which is mandatory in djangoURLValidator
).It create an issue with the regex being different between django version. As it is use directly as validator, it create diff in django migration when changing python version.
In order to ensure stable behavior with multiple version of django, this part has been removed as a quick solution.
dd5b08a
One of the solution could be to create a
CustomURLValidator
fromURLValidator
and override the__call__
method to only validate the url and skip the scheme validation part.cf: https://github.com/django/django/blob/main/django/core/validators.py#L117
The text was updated successfully, but these errors were encountered: