Styling docs #7455
Draft
Styling docs #7455
+727
−346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zoran995
force-pushed
the
styling-docs
branch
from
961adaa to
34ce0b1
Compare
zoran995
commented
Feb 7, 2025
| @@ -59,6 +59,7 @@ export default class TableColumnTraits extends ModelTraits { | |||
| "The type of the column. If not specified, the type is guessed from " + | |||
| "the column's name and values. Valid types are:\n\n" + | |||
| Object.keys(TableColumnType) | |||
| .filter((type) => isNaN(Number(type))) | |||
There was a problem hiding this comment.
Filter out numeric values from enum keys. Maybe those works, but they aren't useful for users as changes in the enum can break them easily
There was a problem hiding this comment.
Perhaps that information should be put in a comment in the source code so it's easily available for future readers?
pjonsson
reviewed
Feb 10, 2025
Comment on lines
+124
to
+125
| "type": "dateTime"; | ||
| "format": "dd-mm-yyyy HH:MM:ss"; |
There was a problem hiding this comment.
Are the ending semicolons meant to be commas?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
Fixes #7352 - first part
Update documentation on data styling to align with changes made in v8.
Test me
Doc only change
Checklist
[ ] There are unit tests to verify my changes are correct or unit tests aren't applicable (if so, write quick reason why unit tests don't exist)doc only changedoc/.[ ] I've provided instructions in the PR description on how to test this PR.doc only change