BINDINGS in Link should be BINDINGS = [Binding("enter", "focused.open_link", "Open link")]?

[python-and-novella]

textual/src/textual/widgets/_link.py

Line 23 in 7c25ab5

BINDINGS = [Binding("enter", "select", "Open link")]

Maybe BINDINGS = [Binding("enter", "focused.open_link", "Open link")] is right.
Then I can press enter to open link.

[github-actions]

We found the following entry in the FAQ which you may find helpful:

• How do I center a widget in a screen?

Feel free to close this issue if you found an answer in the FAQ. Otherwise, please give us a little time to review.

This is an automated reply, generated by FAQtory

[TomJGooding]

Good catch! This looks like a simple fix, but I'm wondering why you changed this to focused.open_link rather than simply open_link?

[github-actions]

Don't forget to star the repository!

Follow @textualizeio for Textual updates.

[github-actions]

Don't forget to star the repository!

Follow @textualizeio for Textual updates.

[python-and-novella]

@TomJGooding I‘m writing a chinese guide of Textual. But I am not very familiar with Textual.
So, in #5451, I don't understand the namespace of button's action.
In order that the action of link will be executed successfully, I think focused must be right.

[TomJGooding]

You don't need to add a focused namespace for bindings:

When you press a key, Textual will first check for a matching binding in the BINDINGS list of the currently focused widget. If no match is found, it will search upwards through the DOM all the way up to the App looking for a match.

I've never actually used the action param of the Button, but from a quick look at the code this behaves differently as by calling the action from the app:

textual/src/textual/widgets/_button.py

Lines 284 to 289 in 699cc86

	if self.action is None:
	self.post_message(Button.Pressed(self))
	else:
	self.call_later(
	self.app.run_action, self.action, default_namespace=self._parent
	)