From 3376880740114434742fe57beeb77b74d2e8950a Mon Sep 17 00:00:00 2001 From: Chris Mc Date: Thu, 18 Jul 2024 07:09:35 -0700 Subject: [PATCH 1/2] Disable gcc-4.8 since node20 is now required (#356) --- .github/workflows/targets.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/targets.yml b/.github/workflows/targets.yml index dfda4986f..c58ab7cad 100644 --- a/.github/workflows/targets.yml +++ b/.github/workflows/targets.yml @@ -15,6 +15,7 @@ on: jobs: gcc-4-8: + if: false # There's no existing image with node20 and gcc4.8 https://github.com/actions/checkout/issues/1809 name: GCC 4.8 runs-on: ubuntu-latest container: From b36e8a988613d3b67b865ae9a58e13ce8297b528 Mon Sep 17 00:00:00 2001 From: KidDigital Date: Mon, 29 Jul 2024 06:52:59 +0200 Subject: [PATCH 2/2] Jsoncpp traits no longer uses deprecated Reader (#357) * Jsoncpp traits no longer uses depricated Reader * linter changes --------- Co-authored-by: Christopher McArthur --- .../jwt-cpp/traits/open-source-parsers-jsoncpp/traits.h | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/include/jwt-cpp/traits/open-source-parsers-jsoncpp/traits.h b/include/jwt-cpp/traits/open-source-parsers-jsoncpp/traits.h index 0f420a233..5442ba0f8 100644 --- a/include/jwt-cpp/traits/open-source-parsers-jsoncpp/traits.h +++ b/include/jwt-cpp/traits/open-source-parsers-jsoncpp/traits.h @@ -117,8 +117,11 @@ namespace jwt { } static bool parse(value_type& val, string_type str) { - Json::Reader reader; - return reader.parse(str, val); + Json::CharReaderBuilder builder; + const std::unique_ptr reader(builder.newCharReader()); + + return reader->parse(reinterpret_cast(str.c_str()), + reinterpret_cast(str.c_str() + str.size()), &val, nullptr); } static string_type serialize(const value_type& val) {