Issue with Tome of Knowledge Sharing

[SanteriLoitomaa]

Version: Thaumic Tinkerer 1.12.2 5.0 BETA1.3

Mods:

• Baubles
• Enchanting With Thaumcraft
• Inventory Tweaks [1.12 only]
• Just Enough Items (JEI)
• Thaumcraft
• Thaumcraft 6 Aspects for JEI
• Thaumic Augmentation
• Thaumic Brewing
• Thaumic Gadgets
• Thaumic Inventory Scanning (Thaumcraft Addon)
• Thaumic JEI
• Thaumic Tinkerer
• Thaumic Wonders

What happened?
Tome of Knowledge Sharing seems to pass on the fact that an item has been scanned but none of the observations gained from doing so, thus softlocking any newbie who reads a book of an experienced Thaumaturge.

Is this intended, a bug, or a compability issue?

[GaeaKat]

This is a bug, and a breaking one , it will be fixed within the month.

[SanteriLoitomaa]

I think I might have found a solution that weeds out everything else than the completed research entries from the completed researches list. After taking a look at how the similar item of Thaumic Additions works, replacing the line 56
if (ThaumcraftCapabilities.getKnowledge(playername).isResearchComplete(tag))
in the ItemShareBook.java with the lines

ResearchEntry entry;
if ((entry = ResearchCategories.getResearch(tag)) != null && entry.getStages() != null && ThaumcraftCapabilities.getKnowledge(playername).isResearchComplete(tag))

seems to leave only the completed research. Should I make a pull request somewhere or are you going to take it from here?

[GaeaKat]

That .. has nothing to do with observations. I am in the progress of a solution that stores observations also

[SanteriLoitomaa]

Ah I see, you're going with that route. Well that's harder to balance but probably better than only sharing the research entries. Are you going to save Theories as well or only Observations?

[GaeaKat]

Just observations,. if I recall theories cant softlock