Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add running times to .json files #2506

Open
oharboe opened this issue Oct 24, 2024 · 6 comments
Open

Add running times to .json files #2506

oharboe opened this issue Oct 24, 2024 · 6 comments

Comments

@oharboe
Copy link
Collaborator

oharboe commented Oct 24, 2024

Description

Based on my current best understanding, I would like to see the following added to the .json files:

  • Add running time for .json file that the step corresponds to

Once running time is in the .json file, the make elapsed could be modified to use .json file information to reduce code duplication.

Suggested Solution

Add running time to .json file

Additional Context

No response

@oharboe
Copy link
Collaborator Author

oharboe commented Oct 24, 2024

@jeffng-or FYI

@maliberty
Copy link
Member

Runtimes are fine to add (though I wouldn't set any metric limit on them).

Just because you have small skew/crpr on the worst path doesn't really tell you a lot. You might have terrible values on the second-worst path. What decision will you make based on these metrics?

@oharboe
Copy link
Collaborator Author

oharboe commented Oct 28, 2024

@maliberty Add running times for now and close this issue?

As you say, skew/CRPR is more of an in depth investigation than a simple metric issue.

@maliberty
Copy link
Member

Add running times for now and close this issue?

Yes. Are you planning to make a PR or requesting PII do it?

@oharboe
Copy link
Collaborator Author

oharboe commented Oct 28, 2024

Add running times for now and close this issue?

Yes. Are you planning to make a PR or requesting PII do it?

It is a feature request to the community. It is not urgent. You asked why I'm not using the .json files in megaboom and I filed a few github issues w.r.t. issues with using the .json files.

@oharboe
Copy link
Collaborator Author

oharboe commented Oct 28, 2024

make elapsed could be rolled into .json if generation of .json files works SKIP_REPORT_METRICS=0

@oharboe oharboe changed the title Add running times and skew to .json files Add running times to .json files Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants