You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When the odb/test/cpp/scan/TestScanChain.cpp test is run, it creates two files at the top of the OR workspace:
CreateScanChain
CreateScanChainWithPartition
The SetUpTmpPath() method defines the location based on BASE_DIR and PWD.
Shouldn't the test clean up after itself and nuke the files? Or add them to the .gitignore?
Expected Behavior
git status doesn't show the files, either because they've been removed or they are ignored.
Environment
Latest OR master
To Reproduce
Run the ODB unit tests and then do a git status:
$ git status
On branch master
Your branch is up to date with 'origin/master'.
...
Untracked files:
(use "git add <file>..." to include in what will be committed)
CreateScanChain
CreateScanChainWithPartition
Relevant log output
No response
Screenshots
No response
Additional Context
No response
The text was updated successfully, but these errors were encountered:
After discussion with Matt, we agreed that the test-generated files should be placed in a results directory somewhere where they can be left, but ignored. The behavior that I've seen with TestScanChain is that it will place the files in the current working directory, but we really should put it in odb/test/results.
The other interesting thing is that TestGDSIn uses the testTmpPath() method to figure out where its input GDS files are. If you run the script from anywhere other than odb/test, it fails.
The BASE_DIR env var is not set in either case, so the method just returns the current working directory.
Describe the bug
When the odb/test/cpp/scan/TestScanChain.cpp test is run, it creates two files at the top of the OR workspace:
The SetUpTmpPath() method defines the location based on BASE_DIR and PWD.
Shouldn't the test clean up after itself and nuke the files? Or add them to the .gitignore?
Expected Behavior
git status doesn't show the files, either because they've been removed or they are ignored.
Environment
To Reproduce
Run the ODB unit tests and then do a git status:
Relevant log output
No response
Screenshots
No response
Additional Context
No response
The text was updated successfully, but these errors were encountered: