Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TestScanChain.cpp leaves "artifacts" after run #6388

Open
jeffng-or opened this issue Dec 19, 2024 · 1 comment
Open

TestScanChain.cpp leaves "artifacts" after run #6388

jeffng-or opened this issue Dec 19, 2024 · 1 comment
Assignees
Labels
dft Design For Test

Comments

@jeffng-or
Copy link
Contributor

Describe the bug

When the odb/test/cpp/scan/TestScanChain.cpp test is run, it creates two files at the top of the OR workspace:

  1. CreateScanChain
  2. CreateScanChainWithPartition

The SetUpTmpPath() method defines the location based on BASE_DIR and PWD.

Shouldn't the test clean up after itself and nuke the files? Or add them to the .gitignore?

Expected Behavior

git status doesn't show the files, either because they've been removed or they are ignored.

Environment

Latest OR master

To Reproduce

Run the ODB unit tests and then do a git status:

$ git status
On branch master
Your branch is up to date with 'origin/master'.

...

Untracked files:
  (use "git add <file>..." to include in what will be committed)
	CreateScanChain
	CreateScanChainWithPartition

Relevant log output

No response

Screenshots

No response

Additional Context

No response

@maliberty maliberty added the dft Design For Test label Dec 19, 2024
@jeffng-or
Copy link
Contributor Author

After discussion with Matt, we agreed that the test-generated files should be placed in a results directory somewhere where they can be left, but ignored. The behavior that I've seen with TestScanChain is that it will place the files in the current working directory, but we really should put it in odb/test/results.

The other interesting thing is that TestGDSIn uses the testTmpPath() method to figure out where its input GDS files are. If you run the script from anywhere other than odb/test, it fails.

The BASE_DIR env var is not set in either case, so the method just returns the current working directory.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dft Design For Test
Projects
None yet
Development

No branches or pull requests

2 participants