Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interaction between macro placement blockages, rsz repair_design, and gpl #6394

Open
gudeh opened this issue Dec 19, 2024 · 4 comments
Open
Assignees
Labels
gpl Global Placement rsz Resizer

Comments

@gudeh
Copy link
Contributor

gudeh commented Dec 19, 2024

Description

Right after a non-virtual timing-driven iteration by gpl, where we keep the resizing and buffers inserted by rsz repair_design we can see instances added on top of macro placement blockages, such as the following image:
image

Gpl does not allow for instances on top of macros, so it moves the instances outside of the positions set by rsz, which are further away, potentially undoing rsz's work:
image

I wonder if we should worry about this behavior.

Suggested Solution

No response

Additional Context

No response

@eder-matheus eder-matheus added the gpl Global Placement label Dec 20, 2024
@maliberty
Copy link
Member

rsz needs to be blockage aware. Right now it just uses Steiner trees and placing instances along the tree edges without such consideration. Its more of an rsz issue than a gpl one.

@maliberty maliberty added the rsz Resizer label Dec 23, 2024
@maliberty
Copy link
Member

@gudeh are you wanting to look into this or pass it to @precisionmoon ?

@gudeh
Copy link
Contributor Author

gudeh commented Dec 24, 2024

If rsz needs to be blockage-aware, I think it would make more sense for someone with more experience in rsz to tackle this issue.

Furthermore, I wonder if this behavior has some impact on gpl divergences. Currently, I suspect that the change in area is the cause for gpl diverging.

@maliberty
Copy link
Member

I wouldn't expect it to cause divergence but I can't say for sure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gpl Global Placement rsz Resizer
Projects
None yet
Development

No branches or pull requests

4 participants