mpl2: apply constraint relaxation until we find a reasonable split when using PAR #6401
+33
−22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Arthur Koucher <[email protected]>
|
clang-tidy review says "All clean, LGTM! 👍" |
|
If the approach is ok, I'll run Secure-CI |
gadfort
reviewed
Dec 20, 2024
Signed-off-by: Eder Monteiro <[email protected]>
|
clang-tidy review says "All clean, LGTM! 👍" |
maliberty
approved these changes
Dec 23, 2024
|
Error: MPL 0041 used 2 times, next free message id is 45 |
Signed-off-by: Eder Monteiro <[email protected]>
Signed-off-by: Eder Monteiro <[email protected]>
|
@maliberty I will run a secure-ci before merging this PR. I don't expect changes in there, but I'll do it to ensure nothing will break. |
|
clang-tidy review says "All clean, LGTM! 👍" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve #6397
Resolve #6083
Due to the discrepancy that may exist between the weight of vertices that represent macros/std cells, PAR may fail to meet the balance constraint defined within MPL2. This may cause the output to be completely unbalanced and lead to infinite partitioning recursion.
The changes here are to apply a relaxation to the constraint until we find a reasonable split.