Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the CLI usable without rustup #272

Open
TimJentzsch opened this issue Feb 15, 2025 · 0 comments · May be fixed by #287
Open

Make the CLI usable without rustup #272

TimJentzsch opened this issue Feb 15, 2025 · 0 comments · May be fixed by #287
Labels
A-Web Building or running Bevy apps targeting the browser C-Bug A bug in the program D-Straightforward Simple bug fixes and API improvements, docs, test and examples S-Ready-for-Implementation This issue is ready for an implementation PR. Go for it!

Comments

@TimJentzsch
Copy link
Collaborator

We currently assume the user has rustup installed, but that isn't always the case.
This makes the web sub-commands unusable, because they use rustup to check whether the wasm32-unknown-unknown target is installed.

As a quick fix, we could first check whether rustup is installed and if it's not, we simply omit the Wasm target check.

Later on, I assume we will not check this in advance, but parse the command output for the error instead and then do it on demand.

@TimJentzsch TimJentzsch added A-Web Building or running Bevy apps targeting the browser C-Bug A bug in the program D-Straightforward Simple bug fixes and API improvements, docs, test and examples S-Ready-for-Implementation This issue is ready for an implementation PR. Go for it! labels Feb 15, 2025
@TimJentzsch TimJentzsch linked a pull request Feb 26, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Web Building or running Bevy apps targeting the browser C-Bug A bug in the program D-Straightforward Simple bug fixes and API improvements, docs, test and examples S-Ready-for-Implementation This issue is ready for an implementation PR. Go for it!
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant