Make errors more informative when cargo metadata fails #260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BD103
reviewed
Feb 5, 2025
BD103
added
A-CLI
BD103
approved these changes
Feb 7, 2025
BD103
added
S-Waiting-on-Author
TimJentzsch
approved these changes
Feb 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the a call to
cargo metadatafails the only output the user sees is "Error: EOF while parsing a value at line 1 column 0" which doesn't explain anything. This change adds additional context.I have made the choice to try to print stderr if it can be decoded as utf-8 because that is where I believe all the useful stuff will always be. If decoding fails I print the debug format for the Output struct which will at least have some information.
fixes: #242