Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error messages are inconsistent #74

Open
dualcyclone opened this issue Mar 27, 2017 · 0 comments
Open

Error messages are inconsistent #74

dualcyclone opened this issue Mar 27, 2017 · 0 comments

Comments

@dualcyclone
Copy link

dualcyclone commented Mar 27, 2017

EDIT: I initially assumed the issue was with getItem and setItem; but I noticed the message responses for remove respond with a message, and not an error object as per the README.

Original issue below:

getItem and setItem have inconsistent error responses given the other methods.

Eg: in the remove method, if the reference is null, the error response maps as follows:

pluginResult = [CDVPluginResult resultWithStatus: CDVCommandStatus_ERROR messageAsString:@"Reference was null"];

However, in both of the methods suggested, the error response is:

pluginResult = [CDVPluginResult resultWithStatus: CDVCommandStatus_ERROR messageAsInt:3]; //Reference was null

@dualcyclone dualcyclone changed the title Error messages for getItem and setItem are inconsistent Error messages are inconsistent Mar 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants