Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slow reverse windowing in KMeansAD #28

Open
wjyzxcv opened this issue Mar 6, 2025 · 1 comment
Open

Slow reverse windowing in KMeansAD #28

wjyzxcv opened this issue Mar 6, 2025 · 1 comment
Assignees

Comments

@wjyzxcv
Copy link

wjyzxcv commented Mar 6, 2025

The _custom_reverse_windowing method of the KMeansAD class is very slow for long time series, probably because of a for loop being used when trying to "only iterate over window intersections". It seems to me a simple moving average would be much faster without degrading performance. I know it may not be good practice to change the algorithm for benchmark purposes but I hope you could make it an option.

@qhliu26
Copy link
Member

qhliu26 commented Mar 7, 2025

Thank you for your suggestion! We will look into this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants