Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When HDR is enabled, application enters maximum refresh rate available regardless of Xbox settings #141

Open
BradyBrenot opened this issue Aug 9, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@BradyBrenot
Copy link
Contributor

Describe the bug
When HDR is enabled, the application will switch the Xbox to the maximum refresh rate available regardless of its settings. This will stick whenever the application is open until it's force quit.

I assume this is because VideoRenderer::SetHDR is selecting the matching mode with the highest refresh rate

			for (unsigned i = 0; i < modes->Size; i++)
			{
				auto mode = modes->GetAt(i);
				if (mode->ResolutionWidthInRawPixels == m_currentDisplayMode->ResolutionWidthInRawPixels && mode->ResolutionHeightInRawPixels == m_currentDisplayMode->ResolutionHeightInRawPixels && mode->ColorSpace == Windows::Graphics::Display::Core::HdmiDisplayColorSpace::BT2020 && mode->RefreshRate >= m_currentDisplayMode->RefreshRate)
				{
					m_currentDisplayMode = mode;
					hdi->RequestSetCurrentDisplayModeAsync(mode, Windows::Graphics::Display::Core::HdmiDisplayHdrOption::Eotf2084);
					break;
				}

Maybe it makes sense for it to change the refresh rate if the user has set a different frame rate for a host, but probably not even then?

To Reproduce

  1. With a display capable of 120 Hz and 60 Hz connected to the Xbox, set the display refresh rate to 60 Hz in the Xbox Settings app
  2. Open Moonlight
  3. Enable HDR on a host
  4. Connect to the host
  5. Notice that display properties have changed and the display is now at 120 Hz

Expected behavior
The display refresh rate should remain at 60 Hz.

@TheElixZammuto TheElixZammuto added the bug Something isn't working label Aug 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants