Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ColourPicker default color does not match shown color #203

Open
regorxxx opened this issue Feb 17, 2023 · 3 comments
Open

ColourPicker default color does not match shown color #203

regorxxx opened this issue Feb 17, 2023 · 3 comments

Comments

@regorxxx
Copy link

I suppose this is native win behavior... but well, it's really confusing that the displayed color when opening the popup does not match the default color passed.

@marc2k3
Copy link
Contributor

marc2k3 commented Feb 18, 2023

The original code I wrote for JSP absolutely behaves in the way you would expect.

colour

It was for the 1.2.x series which predates SMP by quite some time so any breakage copying/reimplementing the code is a bug.

@regorxxx
Copy link
Author

Must be that then, It has been this way since I started creating scripts, that's why I thought it was a Win native thing.

(also the custom colors are never saved btw)

bug

@marc2k3
Copy link
Contributor

marc2k3 commented Feb 18, 2023

My original implementation did not remember custom colours either. I added it at a later date when it was pointed out to me.

Not my repo but I don't have any other copy of the old version changelog online....

https://github.com/razielanarki/foo_jscript_panel/blob/main/CHANGELOG.md#v2301

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants