Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing tests for many of the Webapi/Dom elements #118

Open
eschaefer opened this issue Nov 28, 2022 · 1 comment
Open

Missing tests for many of the Webapi/Dom elements #118

eschaefer opened this issue Nov 28, 2022 · 1 comment

Comments

@eschaefer
Copy link

eschaefer commented Nov 28, 2022

I'm trying to add support for HTMLMediaElement and HTMLVideoElement and wondered what a canonical way of adding tests should look like. This made me notice that tests are actually missing for many of the elements in the Webapi/Dom. Just the first few that I noticed immediately:

  • HTMLSelectElement
  • HTMLTextAreaElement
  • HTMLOptionElement

I'm guessing there are many more.

@TheSpyder
Copy link
Owner

The "tests" are not tests in the traditional sense, they exist to check that the generated JS output doesn't change unintentionally. However after a few incidents where the type changed unintentionally, I logged a task (#42) that describes how I'd like tests to be written to address that as well. Some time ago I started a branch where I began that work but then my personal life became busy and I haven't gone back to it since.

Help is certainly appreciated; you can either start with my branch or create a new one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants