Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove trailing _ from method and parameter names #29

Open
TheSpyder opened this issue Sep 23, 2021 · 0 comments
Open

Remove trailing _ from method and parameter names #29

TheSpyder opened this issue Sep 23, 2021 · 0 comments
Labels
good first issue Good for newcomers

Comments

@TheSpyder
Copy link
Owner

In many cases, ReScript syntax is unambiguous enough that a trailing _ is no longer required in places it was for ReasonML and OCaml syntax. A codebase search for _: turns up quite a lot of them. Examples:
https://github.com/tinymce/rescript-webapi/blob/ea9bd980f1b2b2d516e518f1f9c166feb1073f33/src/Webapi/Webapi__Blob.res#L10

https://github.com/tinymce/rescript-webapi/blob/253ba954381a78b57bad249ea83c1f5b6ab2b428/src/Webapi/Dom/Webapi__Dom__HtmlFormElement.res#L17

The compiler will signal when removing the underscore is not allowed, making this a mostly trivial change (but some tests would be nice)
@TheSpyder TheSpyder added the good first issue Good for newcomers label Sep 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@TheSpyder