Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Devices from other application with similar device-id prefix shown in sidebar's top end devices #7468

Open
1 of 6 tasks
StevenCellist opened this issue Jan 10, 2025 · 3 comments
Labels
needs/triage We still need to triage this

Comments

@StevenCellist
Copy link

Summary

I have access to two applications, both with devices that have their device-id starting with mapquester. Similar to #7321, these devices show up in the other application, but apparently also in the sidebar which I didn't notice before.

Steps to Reproduce

  1. Create two applications
  2. Register devices in both that have an identical prefix for their device-ids
  3. Check the top end devices once they appear there

Current Result

There are only two devices in this application, but the sidebar on the left lists four more (R/G/B/001a) that are from a similar but other application. Not actually a leak because I have access to both either way, but not very much supposed to happen :)
image

Expected Result

Don't show the devices :)

Relevant Logs

No response

URL

No response

Deployment

The Things Stack Community Edition

The Things Stack Version

v3.33.0.3c8e962fdd

Client Name and Version

No response

Other Information

No response

Proposed Fix

No response

Contributing

  • I can help by doing more research.
  • I can help by implementing a fix after the proposal above is approved.
  • I can help by testing the fix before it's released.

Validation

Code of Conduct

@StevenCellist StevenCellist added the needs/triage We still need to triage this label Jan 10, 2025
@KrishnaIyer
Copy link
Member

Hmm I don't think we use a prefix to filter the device IDs, we use the application identifier. @ryaplots can you see if we can reproduce this?

@StevenCellist
Copy link
Author

FYI: the application ID for both applications also use the same prefix 😅 (mapquester vs mapquester-v1).

@ryaplots
Copy link
Contributor

ryaplots commented Jan 13, 2025

Yeah so we indeed don't use prefixs to filter either device IDs or application IDs. I took a quick look and couldn't reproduce this. But what happens in the screenshot is indeed wrong, because only the top devices of the currently open application should be displayed in the applications layer. So I will look more into it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs/triage We still need to triage this
Projects
None yet
Development

No branches or pull requests

3 participants