Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fullscreen button in Android #52

Open
isAlmogK opened this issue Sep 19, 2017 · 12 comments
Open

Add fullscreen button in Android #52

isAlmogK opened this issue Sep 19, 2017 · 12 comments
Assignees
Labels
enhancement stale Closed due to inactivity or lack or resources

Comments

@isAlmogK
Copy link

isAlmogK commented Sep 19, 2017

The full-screen option is not showing on Andriod not sure why. I'm using the lastest version

"react-native-video": "^2.0.0",
"react-native-video-controls": "^1.3.0",
"react-native-video-player": "^0.8.2", 

Here is my code

<VideoPlayer
   endWithThumbnail
   thumbnail={{uri: selectedPhoto.url.thumbnail}}
   video={{uri: selectedPhoto.url.compressedFile}}
   disableFullscreen={false}
/>
@cornedor
Copy link
Collaborator

Fullscreen isn't fully implemented in Android yet, you can check out this pull request #38. The readme has some instructions on how to set it up.

@isAlmogK
Copy link
Author

@cornedor any reason the PR was not merged?

@cornedor
Copy link
Collaborator

If I do you have to manually copy the native code from a folder in node_modules. If you do not do that you get an error. I still have to put some time into getting this to work with react-native link

@isAlmogK
Copy link
Author

@cornedor yea that would be great if it can work with jus react native link

@bisht2ankit
Copy link

Still full-screen option is not showing on Andriod

1 similar comment
@NitishAgrawal
Copy link

Still full-screen option is not showing on Andriod

@TheDanielMoli TheDanielMoli self-assigned this Jun 11, 2020
@TheDanielMoli TheDanielMoli pinned this issue Jun 11, 2020
@TheDanielMoli TheDanielMoli changed the title FullScreen option no showing on Android Add fullscreen button in Android Jun 11, 2020
@meliodev
Copy link

meliodev commented Aug 4, 2020

Is there any update on this ? :(

@TheDanielMoli
Copy link
Collaborator

There is no solution worthy of being published yet. Feel free to look into it! Sadly, this feature requires consistent Java and Android knowledge.

@aschambers
Copy link

I have a fork of the repository to add the fullscreen button on Android. If you add the native module in Android for the video player in your app, it will show the fullscreen button and work: https://github.com/aschambers/react-native-video-player
Of course this requires some knowledge of Android and Java though.

@sinafbd
Copy link

sinafbd commented Nov 19, 2020

i have same problem after doing all the things mentioned for android full screen

@ttibau
Copy link

ttibau commented Oct 25, 2021

Some update here?

@TheDanielMoli TheDanielMoli unpinned this issue Jun 9, 2022
Copy link
Contributor

This issue is stale because it has been open for 30 days with no activity. If there won't be any activity in the next 14 days, this issue will be closed automatically.

@github-actions github-actions bot added the stale Closed due to inactivity or lack or resources label Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement stale Closed due to inactivity or lack or resources
Projects
None yet
Development

No branches or pull requests

9 participants