Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]: 6.9 has compile errors when compiling for tvOS #4365

Open
lostb1t opened this issue Jan 9, 2025 · 3 comments · May be fixed by #4369
Open

[BUG]: 6.9 has compile errors when compiling for tvOS #4365

lostb1t opened this issue Jan 9, 2025 · 3 comments · May be fixed by #4369
Labels

Comments

@lostb1t
Copy link

lostb1t commented Jan 9, 2025

Version

6.9

What platforms are you having the problem on?

Apple tvOS

System Version

18.2

On what device are you experiencing the issue?

Simulator

Architecture

Old architecture

What happened?

when compiling the follow error occurs


❌  (node_modules/react-native-video/ios/Video/RCTVideo.swift:1722:12)

  1720 |     @objc
  1721 |     func enterPictureInPicture() {
> 1722 |         if _pip?._pipController == nil {
       |            ^ cannot find '_pip' in scope
  1723 |             initPictureinPicture()
  1724 |             _playerViewController?.allowsPictureInPicturePlayback = true
  1725 |         }


❌  (node_modules/react-native-video/ios/Video/RCTVideo.swift:1724:36)

  1722 |         if _pip?._pipController == nil {
  1723 |             initPictureinPicture()
> 1724 |             _playerViewController?.allowsPictureInPicturePlayback = true
       |                                    ^ 'allowsPictureInPicturePlayback' is only available in tvOS 14.0 or newer
  1725 |         }
  1726 |         _pip?.enterPictureInPicture()
  1727 |     }


❌  (node_modules/react-native-video/ios/Video/RCTVideo.swift:1726:9)

  1724 |             _playerViewController?.allowsPictureInPicturePlayback = true
  1725 |         }
> 1726 |         _pip?.enterPictureInPicture()
       |         ^ cannot find '_pip' in scope
  1727 |     }
  1728 | 
  1729 |     @objc


❌  (node_modules/react-native-video/ios/Video/RCTVideo.swift:1733:9)

  1731 |         guard isPictureInPictureActive() else { return }
  1732 | 
> 1733 |         _pip?.exitPictureInPicture()
       |         ^ cannot find '_pip' in scope
  1734 |         #if os(iOS)
  1735 |             if _enterPictureInPictureOnLeave {
  1736 |                 initPictureinPicture()

Reproduction Link

repository link

Reproduction

create a project with expo, react native tvOS and react native video 6.9

run with EXPO_TV=1 expo run:ios

@lostb1t lostb1t added the bug label Jan 9, 2025
Copy link

github-actions bot commented Jan 9, 2025

Previous bot comment (click to expand)

Thank you for your issue report. Please note that the following information is missing or incomplete:

  • version
  • reproduction link

Please update your issue with this information to help us address it more effectively.

Note: issues without complete information have a lower priority

There is a newer version of the library available. You are using version 6.9, while the latest stable version is 6.9.0. Please update to the latest version and check if the issue still exists.

Note: If the issue still exists, please update the issue report with the latest information.

@lostb1t lostb1t changed the title [BUG]: 6.9 has compile errors when using with react-native-tvos and expo [BUG]: 6.9 has compile errors when compiling for tvOS Jan 9, 2025
Copy link

github-actions bot commented Jan 9, 2025

Thank you for your issue report. Please note that the following information is missing or incomplete:

  • version
  • reproduction link

Please update your issue with this information to help us address it more effectively.

Note: issues without complete information have a lower priority

There is a newer version of the library available. You are using version 6.9, while the latest stable version is 6.9.0. Please update to the latest version and check if the issue still exists.

Note: If the issue still exists, please update the issue report with the latest information.

@VasylMartyniv
Copy link

Have this issue too

@YangJonghun YangJonghun linked a pull request Jan 13, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants