Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A lot of code checks for groups being restored rather than session being restored #24

Open
ThosRTanner opened this issue Jul 13, 2020 · 1 comment
Labels
bug Something isn't working

Comments

@ThosRTanner
Copy link
Owner

Which'd mean odd things could happen. At least one place says it's checking for session to have been restored.

@ThosRTanner ThosRTanner added the bug Something isn't working label Jul 13, 2020
@ThosRTanner
Copy link
Owner Author

ThosRTanner commented Jul 20, 2020

Note: session restored is problematic as there is one session object for each window (which is in itself questionable as a session is browser wide), and only the one from the main window gets the begin/end events.
On the other hand I'm not sure how one could validly be in a state where the groups weren't valid (unless you somehow managed to create a tab between window loading and first tab being restored).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant