Always upload binaries from branch "nightly-build" #169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I confirmed that last night's feedstock builds uploaded nightly binaries for both tiledb-feedstock and tiledb-py-feedstock |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While troubleshooting the tiledb-py-feedstock failures in #167, I realized that no tiledb-py nightly conda binaries have been uploaded in at least a week (since we delete any older than 7 days).
https://anaconda.org/tiledb/tiledb-py/files
Looking at last night's Azure build log, it says "The branch nightly-build is not configured to be uploaded"
I was initially puzzled since we haven't made any related modifications recently to hte tiledb-py-feedstock nightly builds, but I eventually figured it out. Two months ago I added
upload_on_branch: mainto tiledb-py-feedstock to prevent accidental uploads from internal branches (conda-forge/tiledb-py-feedstock#250).The fix is straightforward. I don't even need to substitute the existing value of
upload_on_branch. I confirmed locally thatconda-smithywill just use the latest value. I also manually triggered a run from this branch.