-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add solver job start event #1084
Conversation
We've already added events before, haven't we? The solution initialization event comes to mind. |
We used the
In this case, it is a solver event and should be called once during We may consider creating a separate issue to refactor |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good so far.
core/src/main/java/ai/timefold/solver/core/impl/solver/ConsumerSupport.java
Outdated
Show resolved
Hide resolved
core/src/main/java/ai/timefold/solver/core/api/solver/SolverJobBuilder.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please switch to listen to the proper event. After that, LGTM.
core/src/main/java/ai/timefold/solver/core/impl/solver/DefaultSolverJob.java
Show resolved
Hide resolved
8a9b781
to
8bf70e2
Compare
c21e3c5
to
c017ec2
Compare
5159618
to
9b07d99
Compare
9b07d99
to
f14444c
Compare
core/src/main/java/ai/timefold/solver/core/impl/solver/DefaultSolverManager.java
Outdated
Show resolved
Hide resolved
|
This pull request adds a new job configuration that allows an action to be run when the solver starts the solving process. The current approach uses a
PhaseLifecycleListenerAdapter
to trigger the event because the APISolverEventListener
would need to be changed in order to add a new solver event.