chore: fail fast when score corruption detected #1411
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 24, 2025
zepfred
reviewed
Feb 24, 2025
benchmark/src/main/java/ai/timefold/solver/benchmark/impl/report/BenchmarkReport.java
Outdated
Show resolved
Hide resolved
zepfred
reviewed
Feb 24, 2025
core/src/main/java/ai/timefold/solver/core/config/solver/EnvironmentMode.java
Outdated
Show resolved
Hide resolved
zepfred
reviewed
Feb 24, 2025
core/src/main/java/ai/timefold/solver/core/config/solver/EnvironmentMode.java
Outdated
Show resolved
Hide resolved
zepfred
reviewed
Feb 24, 2025
core/src/main/java/ai/timefold/solver/core/config/solver/EnvironmentMode.java
Outdated
Show resolved
Hide resolved
zepfred
reviewed
Feb 24, 2025
core/src/main/java/ai/timefold/solver/core/config/solver/EnvironmentMode.java
Show resolved
Hide resolved
zepfred
reviewed
Feb 24, 2025
core/src/main/java/ai/timefold/solver/core/config/solver/EnvironmentMode.java
Outdated
Show resolved
Hide resolved
zepfred
reviewed
Feb 24, 2025
core/src/main/java/ai/timefold/solver/core/config/solver/EnvironmentMode.java
Outdated
Show resolved
Hide resolved
zepfred
reviewed
Feb 24, 2025
...imefold/solver/core/impl/constructionheuristic/DefaultConstructionHeuristicPhaseFactory.java
Show resolved
Hide resolved
zepfred
reviewed
Feb 24, 2025
core/src/main/java/ai/timefold/solver/core/config/solver/EnvironmentMode.java
Outdated
Show resolved
Hide resolved
zepfred
reviewed
Feb 24, 2025
core/src/main/java/ai/timefold/solver/core/config/solver/EnvironmentMode.java
Outdated
Show resolved
Hide resolved
zepfred
reviewed
Feb 24, 2025
core/src/main/java/ai/timefold/solver/core/impl/score/director/AbstractScoreDirector.java
Outdated
Show resolved
Hide resolved
zepfred
reviewed
Feb 24, 2025
core/src/main/java/ai/timefold/solver/core/impl/solver/DefaultSolverFactory.java
Show resolved
Hide resolved
zepfred
reviewed
Feb 24, 2025
There was a problem hiding this comment.
One more after addressing the comments.
Please check CI because there is one failing test.
https://github.com/TimefoldAI/timefold-solver/actions/runs/13502108292/job/37722850012?pr=1411
…/AbstractScoreDirector.java Co-authored-by: Frederico Gonçalves <[email protected]>
|
triceo
added a commit
to TimefoldAI/timefold-quickstarts
that referenced
this pull request
Feb 25, 2025
triceo
added a commit
to triceo/timefold-solver
that referenced
this pull request
Feb 25, 2025
Also add a whole bunch of unrelated fixes to flaky tests, because with this PR, they started showing up more frequently. Closes TimefoldAI#1402 --------- Co-authored-by: Frederico Gonçalves <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1402