From 283b21e95d7bfbd87bc978fadc047244971d5a9b Mon Sep 17 00:00:00 2001 From: Thomas Beierlein Date: Thu, 22 Feb 2024 19:58:59 +0100 Subject: [PATCH 1/4] Cleans up an ambiguous example in the man page Using parameter -f kills the first program which contains the mentioned 'rec' string in its command line. That may not be the program with the name 'rec'. --- tlf.1.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tlf.1.in b/tlf.1.in index e49498ad..3817288b 100644 --- a/tlf.1.in +++ b/tlf.1.in @@ -606,7 +606,7 @@ shown): . .P .EX -/usr/bin/pkill \-f rec +/usr/bin/pkill \-x rec .EE . .P From 4a149777a5d2ecf3e48cd6c3ec2650c404fb94ef Mon Sep 17 00:00:00 2001 From: Nate Bargmann Date: Tue, 20 Feb 2024 03:57:12 -0600 Subject: [PATCH 2/4] Replace backticks with $() in scripts/soundlog As backticks are generally hard to see, use the synonymous $() construct to generate the name for the audio file. $() is preferred for capturing the output of a command into a shell variable. --- scripts/soundlog | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/soundlog b/scripts/soundlog index ca0cbdfa..e61ec9d1 100755 --- a/scripts/soundlog +++ b/scripts/soundlog @@ -8,7 +8,7 @@ trap 'kill -s INT $PID' TERM USR1 while [ -f $HOME/.VRlock ] do # store recorded files in actual directory - filename=`eval date +%d%H%M`".au" + filename=$(eval date +%d%H%M)".au" if test -f $filename then sleep 10 From c9586124e74506753d9a1900002e4d1792665709 Mon Sep 17 00:00:00 2001 From: Thomas Beierlein Date: Thu, 22 Feb 2024 20:15:24 +0100 Subject: [PATCH 3/4] Typo --- scripts/play_vk | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/play_vk b/scripts/play_vk index 7ca08ac6..8c910111 100755 --- a/scripts/play_vk +++ b/scripts/play_vk @@ -27,7 +27,7 @@ trap 'kill -s KILL $PID' TERM INT # mute mic #amixer -c 0 set Mic mute -q -# play file on the default sound device in background, so signals can be catch +# play file on the default sound device in background, so signals can be catched # by the 'trap' instruction above # SoX play utility syntax From 783244db638f437082b66d458744ae85d07e8037 Mon Sep 17 00:00:00 2001 From: Thomas Beierlein Date: Fri, 23 Feb 2024 09:04:05 +0100 Subject: [PATCH 4/4] add feedback from native speaker --- scripts/play_vk | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/play_vk b/scripts/play_vk index 8c910111..5963ad8a 100755 --- a/scripts/play_vk +++ b/scripts/play_vk @@ -27,7 +27,7 @@ trap 'kill -s KILL $PID' TERM INT # mute mic #amixer -c 0 set Mic mute -q -# play file on the default sound device in background, so signals can be catched +# play file on the default sound device in background, so signals can be caught # by the 'trap' instruction above # SoX play utility syntax