diff --git a/NetCore8583.Test/NetCore8583.Test.csproj b/NetCore8583.Test/NetCore8583.Test.csproj index fe5409f..c5a961d 100644 --- a/NetCore8583.Test/NetCore8583.Test.csproj +++ b/NetCore8583.Test/NetCore8583.Test.csproj @@ -1,4 +1,4 @@ - + @@ -16,11 +16,11 @@ true - + - - + + all runtime; build; native; contentfiles; analyzers; buildtransitive diff --git a/NetCore8583/MessageFactory.cs b/NetCore8583/MessageFactory.cs index 1e10143..1ddb694 100644 --- a/NetCore8583/MessageFactory.cs +++ b/NetCore8583/MessageFactory.cs @@ -132,7 +132,6 @@ public Encoding Encoding } } } - public void SetCustomField(int index, ICustomField value) { diff --git a/NetCore8583/NetCore8583.csproj b/NetCore8583/NetCore8583.csproj index fc3f1df..9aaca25 100644 --- a/NetCore8583/NetCore8583.csproj +++ b/NetCore8583/NetCore8583.csproj @@ -8,6 +8,7 @@ https://opensource.org/licenses/MIT https://github.com/Tochemey/NetCore8583 https://github.com/Tochemey/NetCore8583 + README.md Iso8583 NetCore Banking C# Tochemey 2018-2024 2.2.0 @@ -27,11 +28,11 @@ - + - - + + @@ -39,6 +40,7 @@ Always + diff --git a/NetCore8583/Util/ByteUtil.cs b/NetCore8583/Util/ByteUtil.cs index 963adb5..647b8ae 100644 --- a/NetCore8583/Util/ByteUtil.cs +++ b/NetCore8583/Util/ByteUtil.cs @@ -13,7 +13,7 @@ public static class ByteUtil public static sbyte[] ToInt8(this byte[] bytes) { return Array.ConvertAll(bytes, - b => unchecked((sbyte) b)); + b => unchecked((sbyte)b)); } /// @@ -24,9 +24,17 @@ public static sbyte[] ToInt8(this byte[] bytes) public static byte[] ToUint8(this sbyte[] bytes) { return Array.ConvertAll(bytes, - a => (byte) a); + a => (byte)a); } + /// + /// Converts a signed bytes array to string from a given position to a given length + /// + /// the signed bytes array + /// the starting position + /// the length + /// the encoding to use + /// public static string ToString(this sbyte[] sbytes, int pos, int len, @@ -45,6 +53,12 @@ public static string ToString(this sbyte[] sbytes, } } + /// + /// Converts a signed bytes array to string given a encoding + /// + /// the signed bytes array + /// the encoding to use + /// public static string ToString(this sbyte[] sbytes, Encoding encoding) { diff --git a/code_of_conduct.md b/code_of_conduct.md new file mode 100644 index 0000000..4d1143c --- /dev/null +++ b/code_of_conduct.md @@ -0,0 +1,128 @@ +# Contributor Covenant Code of Conduct + +## Our Pledge + +We as members, contributors, and leaders pledge to make participation in our +community a harassment-free experience for everyone, regardless of age, body +size, visible or invisible disability, ethnicity, sex characteristics, gender +identity and expression, level of experience, education, socio-economic status, +nationality, personal appearance, race, religion, or sexual identity +and orientation. + +We pledge to act and interact in ways that contribute to an open, welcoming, +diverse, inclusive, and healthy community. + +## Our Standards + +Examples of behavior that contributes to a positive environment for our +community include: + +* Demonstrating empathy and kindness toward other people +* Being respectful of differing opinions, viewpoints, and experiences +* Giving and gracefully accepting constructive feedback +* Accepting responsibility and apologizing to those affected by our mistakes, + and learning from the experience +* Focusing on what is best not just for us as individuals, but for the + overall community + +Examples of unacceptable behavior include: + +* The use of sexualized language or imagery, and sexual attention or + advances of any kind +* Trolling, insulting or derogatory comments, and personal or political attacks +* Public or private harassment +* Publishing others' private information, such as a physical or email + address, without their explicit permission +* Other conduct which could reasonably be considered inappropriate in a + professional setting + +## Enforcement Responsibilities + +Community leaders are responsible for clarifying and enforcing our standards of +acceptable behavior and will take appropriate and fair corrective action in +response to any behavior that they deem inappropriate, threatening, offensive, +or harmful. + +Community leaders have the right and responsibility to remove, edit, or reject +comments, commits, code, wiki edits, issues, and other contributions that are +not aligned to this Code of Conduct, and will communicate reasons for moderation +decisions when appropriate. + +## Scope + +This Code of Conduct applies within all community spaces, and also applies when +an individual is officially representing the community in public spaces. +Examples of representing our community include using an official e-mail address, +posting via an official social media account, or acting as an appointed +representative at an online or offline event. + +## Enforcement + +Instances of abusive, harassing, or otherwise unacceptable behavior may be +reported to the community leaders responsible for enforcement at +agandote80@gmail.com +All complaints will be reviewed and investigated promptly and fairly. + +All community leaders are obligated to respect the privacy and security of the +reporter of any incident. + +## Enforcement Guidelines + +Community leaders will follow these Community Impact Guidelines in determining +the consequences for any action they deem in violation of this Code of Conduct: + +### 1. Correction + +**Community Impact**: Use of inappropriate language or other behavior deemed +unprofessional or unwelcome in the community. + +**Consequence**: A private, written warning from community leaders, providing +clarity around the nature of the violation and an explanation of why the +behavior was inappropriate. A public apology may be requested. + +### 2. Warning + +**Community Impact**: A violation through a single incident or series +of actions. + +**Consequence**: A warning with consequences for continued behavior. No +interaction with the people involved, including unsolicited interaction with +those enforcing the Code of Conduct, for a specified period of time. This +includes avoiding interactions in community spaces as well as external channels +like social media. Violating these terms may lead to a temporary or +permanent ban. + +### 3. Temporary Ban + +**Community Impact**: A serious violation of community standards, including +sustained inappropriate behavior. + +**Consequence**: A temporary ban from any sort of interaction or public +communication with the community for a specified period of time. No public or +private interaction with the people involved, including unsolicited interaction +with those enforcing the Code of Conduct, is allowed during this period. +Violating these terms may lead to a permanent ban. + +### 4. Permanent Ban + +**Community Impact**: Demonstrating a pattern of violation of community +standards, including sustained inappropriate behavior, harassment of an +individual, or aggression toward or disparagement of classes of individuals. + +**Consequence**: A permanent ban from any sort of public interaction within +the community. + +## Attribution + +This Code of Conduct is adapted from the [Contributor Covenant][homepage], +version 2.0, available at +https://www.contributor-covenant.org/version/2/0/code_of_conduct.html. + +Community Impact Guidelines were inspired by [Mozilla's code of conduct +enforcement ladder](https://github.com/mozilla/diversity). + +[homepage]: https://www.contributor-covenant.org + +For answers to common questions about this code of conduct, see the FAQ at +https://www.contributor-covenant.org/faq. Translations are available at +https://www.contributor-covenant.org/translations. diff --git a/contributing.md b/contributing.md new file mode 100644 index 0000000..efd3862 --- /dev/null +++ b/contributing.md @@ -0,0 +1,11 @@ +# Contributions are welcome + +The project adheres to [Semantic Versioning](https://semver.org) and [Conventional Commits](https://www.conventionalcommits.org/en/v1.0.0/). + +There are two ways you can become a contributor: + +1. Request to become a collaborator and then you can just open pull requests against the repository without forking it. +2. Follow these steps + - Fork the repository + - Create a feature branch + - Submit a [pull request](https://help.github.com/articles/using-pull-requests) \ No newline at end of file diff --git a/readme.md b/readme.md index 02be343..ff1c07c 100644 --- a/readme.md +++ b/readme.md @@ -1,14 +1,12 @@ # NetCore8583 -[![Stability: Maintenance](https://masterminds.github.io/stability/maintenance.svg)](https://masterminds.github.io/stability/maintenance.html) - _NetCore8583 is considered feature complete and mature. No future feature development is planned, though bugs and security issues are fixed._ - [![GitHub Workflow Status (branch)](https://img.shields.io/github/actions/workflow/status/Tochemey/NetCore8583/ci.yml?branch=main&style=flat-square)](https://github.com/Tochemey/NetCore8583/blob/main/.github/workflows/ci.yml) [![License: MIT](https://img.shields.io/badge/License-MIT-blue.svg?style=flat-square)](https://opensource.org/licenses/MIT) [![Nuget](https://img.shields.io/nuget/v/NetCore8583?style=flat-square)](https://www.nuget.org/packages/NetCore8583/) +[![Stability: Maintenance](https://masterminds.github.io/stability/maintenance.svg)](https://masterminds.github.io/stability/maintenance.html) ## Introduction