Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-export dimnames? #60

Open
kescobo opened this issue Dec 23, 2020 · 3 comments
Open

Re-export dimnames? #60

kescobo opened this issue Dec 23, 2020 · 3 comments
Assignees

Comments

@kescobo
Copy link
Contributor

kescobo commented Dec 23, 2020

I'd like to get the names of dimensions for a NamedAxisArray - googling I found this page on juliahub, but it doesn't seem to be present in v0.7 docs, and dimnames is no longer exported from this package.

Digging through the tests, I figured out I could add NamedDims and then it works. Is this something you'd be willing to import/re-export? Since one can generate NamedAxisArrays from this package, it would be nice to be able to work with them as well without adding an additional direct dependency.

@grahamas
Copy link

Seconded. The function dim(arr::NamedAxisArray, name::Symbol)::Integer was also useful.

@Tokazama
Copy link
Owner

Tokazama commented Jan 4, 2021

it would be nice to be able to work with them as well without adding an additional direct dependency.

I'm going to be moving away from NamedDims.dimnames to ArrayInterface.dimnames soon. In theory if everybody started using ArrayInterface this package would automagically work everywhere.

I do think it's important enough to what this package does that it would make sense to reexport it though. As soon as I catch up on my "real" work for the last week and a half I took off I'll get started on a version using ArrayInterface.dimnames.

@Tokazama Tokazama self-assigned this Jan 4, 2021
@kescobo
Copy link
Contributor Author

kescobo commented Jan 4, 2021

Sounds great 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants