Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit Scope of price recalculation #71

Open
Goosius1 opened this issue Jul 7, 2023 · 1 comment
Open

Limit Scope of price recalculation #71

Goosius1 opened this issue Jul 7, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@Goosius1
Copy link
Collaborator

Goosius1 commented Jul 7, 2023

  • Currently the price recalculation function starts after every regeneration, and recalculates ALL prices in the world
  • This is going to overwrite any custom prices which a server has put on
  • Solution: Limit the recalculation function only to affected provinces:
    • Some provinces were deleted, we can ignore those
    • Some provinces were added....yes we want to calculate those
    • Some existing provinces may have expanded...yes we want to do those
  • To do this, we need, for every regeneration job, to keep a list of changed provinces e.g.
    • deletedProvinces
    • newProvinces
    • updatedProvinces
@Goosius1 Goosius1 added this to the 1.12.0 milestone Jul 7, 2023
@Goosius1 Goosius1 added the enhancement New feature or request label Jul 7, 2023
@Goosius1 Goosius1 modified the milestones: 1.12.0, 1.13.0 Jul 9, 2023
@Goosius1
Copy link
Collaborator Author

This work is less important now that the price limiter is in place

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant