Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

So many bugs #12

Open
IAmREGE opened this issue Nov 7, 2024 · 3 comments
Open

So many bugs #12

IAmREGE opened this issue Nov 7, 2024 · 3 comments

Comments

@IAmREGE
Copy link

IAmREGE commented Nov 7, 2024

Bug 1: Command argument with Chinese characters?

See the image below
Bug 1 image
Using tab to complete the command gives a true “关” instead of something like “off”.

Bug 2: Not all block placements could push the fluid

Slab block items are tested that their placements did not push the fluid(level != 8), they just replace it. Maybe all waterloggable block items?

Bug 3: Incorrect command description

/flowing_fluids settings appearance fluid_height outputs:


§7§o/flowing_fluids settings appearance fluid_height§r
Changes the heights fluids render at, currently set to BLOCK.
fluid_height is currently set to: block
§7_____________________________

But setting this item affects not only client rendering, entity behaviours are also affected(at least integrated server)!

@IAmREGE
Copy link
Author

IAmREGE commented Nov 9, 2024

A possible solution of Bug 1 mentioned above:
In traben.flowing_fluids.config.FFCommands: Replace CommonComponents.OPTION_ON.getString().toLowerCase() with "on"; Replace CommonComponents.OPTION_OFF.getString().toLowerCase() with "off".

@Traben-0
Copy link
Owner

I dont quite understand issue 2

i will adress issue 1 & 3 next update

@Goofishguy22
Copy link

from what i can tell about issue 2, they mean that when pushing/placing a slab into a block with water on it, water would not displace

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants