Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allocator::new should be unsafe #160

Open
i509VCB opened this issue Mar 23, 2023 · 0 comments
Open

Allocator::new should be unsafe #160

i509VCB opened this issue Mar 23, 2023 · 0 comments

Comments

@i509VCB
Copy link

i509VCB commented Mar 23, 2023

Allocator::new should not be safe because there is no guarantee the caller has made sure the ash::Device outlives the allocator.

The AllocatorCreateDesc also needs to be populated so that the instance is the one which created the physical device and the device was created from the physical device.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@i509VCB