Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chrome 43 Breaks compiled version #324

Open
styks1987 opened this issue Jun 26, 2015 · 8 comments
Open

Chrome 43 Breaks compiled version #324

styks1987 opened this issue Jun 26, 2015 · 8 comments

Comments

@styks1987
Copy link

I know this project is pretty much on hold, but this bug is breaking a legacy app and it would be greatly appreciated if you could shed some light on why this might be happening. This appears to be a chrome 43 issue that only happens with the compiled version of the script. The debug version loads fine. Here is the error I am getting from the script.

treesaver-0.10.0.js:24 Uncaught TypeError: Cannot set property path of # which has only a getter
treesaver-0.10.0.js:114 Uncaught TypeError: Cannot read property 'parentNode' of null

Let me know if you need more information. Also, if you are not planning on fixing this, please let me know so I can figure out some alternatives.

@styks1987
Copy link
Author

The problem is that UIEvent.path is not writable.
In case anyone cares. Here is what I did to fix this.
On line 30 of the lib/events.js, I made the assignment into a try..catch block.

try{
    e[cur] = data[cur];
 }catch(exception){

 }

Recompile and the error is gone.

@sharcupine
Copy link

I'm so glad you figured out the problem. I don't suppose you'd be willing to share your re-compiled version? I've never compiled any code before, and my site is, of course completely unusable in Chrome right now, so I'd like to get it fixed as quickly as possible.

I'll take a stab at making the change and compiling it myself, but if you could share yours, it would be much appreciated.

Thanks.

@styks1987
Copy link
Author

Here you go. https://gist.github.com/styks1987/3a3add691040d3c7fab5

Learning to compile can be a pain for sure. Especially with cake.

@kmuncie
Copy link
Member

kmuncie commented Jul 14, 2015

@styks1987 would you be able to submit a pull request?

@styks1987
Copy link
Author

#325

@sharcupine
Copy link

Thanks! You're a lifesaver!

@styks1987
Copy link
Author

... or a treesaver.

@FrankHan
Copy link

FrankHan commented Oct 4, 2016

Thanks! It works!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants