CameraControls break on-demand rendering (by invalidating every frame)

[lnvglr]

Describe the bug

I am setting the render-mode on my TresCanvas to on-demand. I am using the CameraControls for controlling orbiting. I expect the @render emitter to fire only briefly when mounting the scene. But instead, it fires on every frame.

<TresCanvas
  preset="realistic"
  render-mode="on-demand"
  @render="console.log('rendering ...')"
>
  <TresPerspectiveCamera />
  <CameraControls v-bind="controlsState" make-default />

  <!-- rest of the scene -->
</TresCanvas>

Commenting out the rest of the scene does not change the behavior, when commenting out <CameraControls />, on-demand returns to working as expected.

FYI: It does not happen with <OrbitControls /> component.

Reproduction

https://stackblitz.com/edit/tresjs-minimal-reproduction-gj1p2u?file=src%2FApp.vue

Steps to reproduce

1. Open console and verify that the @render emitter is firing the console.log
2. Comment out <CameraControls v-bind="controlsState" make-default /> and check the console to verify that logging stops after a few render loops

System Info

No response

Used Package Manager

npm

Code of Conduct

• I agree to follow this project's Code of Conduct
• Read the Contributing Guidelines.
• Read the docs.
• Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
• The provided reproduction is a minimal reproducible example of the bug.

[stackblitz]

Start a new pull request in StackBlitz Codeflow.

• tresjs-minimal-reproduction-gj1p2u (Open reproduction)

[lnvglr]

I have found the location where the invalidate() is called (seemingly incorrectly):

cientos/src/core/controls/CameraControls.vue

Line 432 in 535bd86

invalidate()

Commenting it out does not break the CameraControls, but it fixes the on-demand rendering! So I'll work with a local copy of the component. I'll be happy to make a PR if need be.

Do you think the invalidate() needs to be called there and if so, why?

[JaimeTorrealba]

Hi man, can you check this one when you have time @alvarosabu