Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Digital Basic Identity - EU EBSI gateway and "regie op gegevens" #6023

Closed
synctext opened this issue Mar 10, 2021 · 80 comments
Closed

Digital Basic Identity - EU EBSI gateway and "regie op gegevens" #6023

synctext opened this issue Mar 10, 2021 · 80 comments
Assignees

Comments

@synctext
Copy link
Member

synctext commented Mar 10, 2021

Topic is determined: Digital Basic identity, see https://www.tweedekamer.nl/kamerstukken/brieven_regering/detail?id=2021Z02985&did=2021D06488

Estimated timeline (tentative)

  • 2 weeks: read background, compile prior code, understand ID,wallet and EBSI sandbox
  • 2 months: participate in design team of Digitale Bron Identiteit (Deliver a report, English thesis appendix) (possibly with Generic value transfer primitive - master thesis #6029)
  • Milestone after 2 months: Problem Decription first draft of 3-5 pages, outlines the deep dive direction
  • 1 month: EU EBSI connection/ESSIF with trustchain, our DBI/SSI solution.
  • 5-6 months: master thesis deep dive. Possible directions:
    • Revocation (Pallier, Schnorr, buzzword-3, etc. hard-core crypto)
    • eDemocracy (Bindend Burger Advies trail with 25+ people)
    • Secure Data Sharing (data exchange, data box, real-time chat, and key management)
    • Personal data vault (with some machine learning?)

First sprint target of 2 weeks: see above

@sjacobino
Copy link

@synctext you mentioned the groundwork laid by Rowdy for digital identity. Is there something I can start looking into?

@synctext synctext changed the title Master thesis placeholder issue Digital Basic Identity - EU EBSI gateway and "regie op gegevens" Mar 19, 2021
@sjacobino
Copy link

@synctext
Copy link
Member Author

synctext commented Apr 7, 2021

2 week pause due to circumstances. Code compiles locally, EBSI reading first pass done, pull request Rowdy review on ToDo list.
Recent find: Self-Sovereign Identity (SSI) en Attribute Based Credentials (ABC)

@synctext
Copy link
Member Author

synctext commented Apr 28, 2021

For more context, in 2017 we talked about the "decentralised economy". Identity is the foundation. Others are now also doing this in a token hype manner: https://fetch.ai/wp-content/uploads/2019/10/Fetch.AI-Economics-white-paper.pdf This team actually deployed an IPv8 clone: http://www.ifaamas.org/Proceedings/aamas2021/pdfs/p1037.pdf
More work to read, solid data pods from MIT and web founder.

The current generation of thesis students in the lab.

Student Thesis focus
@InvictusRMC Working SSI. operational attestations. Revocation problem and QR codes. #5576
@jwbambacht Reliable enough for money. Effortless EuroToken transfer in chats. UDP packets always arrive. #6029
@awrgold production-ready DAO. Shared ownership of BTC. Democratic decision making process. #5313

Promising thesis direction: Create an architecture in which Big Tech alternatives can emerge, market failure can be corrected, anti-competitive practices are addressed and consumers win their privacy back. Protecting privacy of users in the age of AI and digital IDs.

ToDo sprint: compiling new Superapp code, revocation of Rowdy code, read litarature.
Future sprint: first draft of problem description, EBSI enrolment

@sjacobino
Copy link

sjacobino commented May 19, 2021

Start on the problem description: Self-Sovereign Shared Identity

Use case is SSI for group subscriptions which includes data sharing and some key management.

SSSI Problem description.pdf

Inspiration for another tangent: fair compensation scheme for personal data in personal vault
https://cordis.europa.eu/event/id/148435-bdve-webinar-bringing-back-personal-data-value-to-the-rightful-owners
https://cordis.europa.eu/project/id/871755

@synctext
Copy link
Member Author

synctext commented May 19, 2021

Good readable first version of problem description. Just replace "family plan" with "legal entity", then it becomes economic relevant and key for SSI. Authorisation within huge companies or hierarchical government is unexplored. Still good to keep in mind we can go in any direction, like ask Schiphol for real on-site tests. Another direction is deep alignment with @jwbambacht his work. Your thesis would focus entirely on getting an encrypted address book (e.g. social graph, friend list) into the Superapp SSI part. Scientifically this is a validated public key infrastructure that would be actually operational and fully decentralised. Signal messaging app has central servers, no such DPKI system exists.
btw about selling your own data. The idea of mixing capitalism of selling data with social value such as data sovereignty is old. The first to publish this, conclude that its a bad idea was these smart people: https://blog.oceanprotocol.com/on-selling-data-in-ocean-market-9afcfa1e6e43 Conclusion, nobody wants that data. This model can't compete against Big Tech who owns you (Mark Zuckerberg called early Facebook users dumb f***s for sharing data when he was just 19 years old).

ToDo idea for coming 2 week, align at the source code branch level with Joost and Rowdy. Get an rvig.nl email; get account for EU EBSI; get a working cmdline Python script working or directly integrate with Superapp.

@synctext
Copy link
Member Author

synctext commented Jun 7, 2021

Possible sprint idea for coming 2+ weeks. Goal: get operational coding experience. Make first Pull Request on the Superapp. For instance, add address book sharing in PeerChat. Any contact entry you have locally (nickname+public key) becomes available to share with your friends. Status: emulator works, next step is old S4 hardware attempt. Search for good thesis focus.

Possible goal:

  • Future sprint: EBSI integration, https://api.ebsi.xyz/docs/
  • Live test, beyond Beta code; international .DE?
  • Expand upon @jwbambacht of "waardeoverdracht" into a Secure Data Sharing primitive. With personal data vaults + exchange.

@sjacobino
Copy link

Preview contact sharing

Uploading IMG_4267_MED_1_1.mp4…

@synctext
Copy link
Member Author

synctext commented Jun 22, 2021

  • Working on thesis for 2-3 months now
  • Contact sharing works, successfully enhanced the Superapp 🎊 Next step: Pull Request!
  • Completion of official RvIG onboarding, next step: EBSI intergration of unknown time duration. repeating get a working cmdline Python script working or directly integrate with Superapp.
  • European Identity wallet: Cross-Country EBSI wallet exchange?
    • Ongoing efforts, no real SSI exists yet, see ongoing projects and wallets. All focussed on the high-cost, high complexity W3C approach with 'universal resolver'.
    • repeating from above Live test, beyond Beta code; international .DE?
    • German solution: online at play store and there is a white paper with some tech details. Verdict: small startup, early stage technology development.
  • Thesis could also add "vault features" and solve problem of "wifi UDP packet dropping" (re-use your experienced Android developer knowledge)
  • Should be move the "reliability aspect" of @jwbambacht Generic value transfer primitive - master thesis #6029 into this thesis, "low-level hardcore nerding" ?
  • Already explore https://github.com/budtmo/docker-android and Superapp?

@sjacobino
Copy link

Preview contact sharing in gif form:

ezgif com-optimize

@sjacobino
Copy link

To do in contact sharing feature:

  • Highlight selected contact in list
  • Multiple contacts at once?

@sjacobino
Copy link

sjacobino commented Jun 25, 2021

@sjacobino
Copy link

Share contacts PR: https://github.com/Tribler/trustchain-superapp/pull/77/commits

Small feature that allows you to send one of your contacts as an attachment in a conversation. Recipient can click on the contact and add it to his/her list.

@sjacobino
Copy link

sjacobino commented Jul 7, 2021

  • Contact sharing Pull request online. Has lint errors that can be fixed.
  • EBSI account is set up. Reading early adopters program, getting feel for Wallet and DID APIs

Next steps:

Current vision/goal

  • IG-SSI integrated into EBSI/ESSIF to send and receive attestations from outside of Trustchain e.g DBI
  • Social app based on the concept of Decentralized Social Applications Based on Linked Data (Solid)
  • Think about a shared calendar, notes, foto album that collects data from the personal online datastore (pod, basically a data vault with acces control), and aggregates the data into a social experience. Apps within and outside of Trustchain Superapp can access users’ pods.

@synctext
Copy link
Member Author

synctext commented Jul 7, 2021

  • EBSI is operational already for NL; account can use "EBSI block browser" (Ethereum lite explorer).
  • How mature is EBSI ESSIF? Can we store our EuroToken there, PeerChat received pictures, IPv8 verifiable Claims, or even gossip-store-and-forward @InvictusRMC revocations?
  • Superapp as an app store for "social enriched" secure apps. Next level ideas, of MIT Solid initial sketches. Is this really mass-uptake realistic? True, if we feed into the EU-wide digital wallet.
  • Trustless execution environment, personal data vault, self-sovereign data access permission and revocation.
  • With this thesis direction, reliability is now minor part only.
  • copied partly Possible storyline for thesis. This thesis matures the existing ideas around personal data and identity into primitives for an automated digital society. Building blocks are personal data vault, self-sovereign identity, verifiable claims, authenticated communication with perfect forward secrecy, cloud-free personalised chat, programmable money, a universal European wallet, and trustless app execution, trustless apps ecosystem. This thesis presents the first Internet-deployed system which brings such a wealth of functionality together. It is designed to be a showcase for the upcoming European digital wallet ecosystem. Cardinal challenge is the integration an unprecedented range of primitives into a viable architecture for an automated digital society: data, identity, money, and self-determination. Furthermore, our elements are meticulously designed to evolve into an Decentralised Autonomous Organisation in coming decade as future work. Our design empowers citizens fully, they control their data and identity; dramatically reducing the power of Big Tech and robots.
    image
  • ToDo:
    • Kotlin cmdline read-write on EBSI / ESSIF
    • Personal data vaults + exchange?
    • Contact exchange Pull Request?
    • Integrate with @jwbambacht ?
    • IPv8 is not 100% reliable. Implement re-try IPv8 transfer, key discovery of strangers, etc. Possible cheat & hack: red status icon if IPv8 has no "IPv4 UDP connection"?

@sjacobino
Copy link

Because of electricity/internet problems, no video call on 23/07/2021.

Updates:

  • Working API interface with test server EBSI (api.ebsi.xyz). I did not manage to get a meeting with Andre last week to discuss using the actual NL test servers hosted by the TU and I did not try again this week. That's my bad. But everything seems to work using dummy calls to the public test server.
  • Instead of making a cmd line app, I directly implemented it in the Super App commons so that it is easier to link it with our wallet code in the next step.
  • Working on an introduction for the new aim: Personal data vaults in the super app, that combined with SSI sovereignty not just over identity, but all data that can be accessed by applications within the super app ecosystem, and services outside (read EBSI). This is a work in progress and a first draft can be expected next week.
  • The productivity has taken a hit this week but there enough to do still (see uncompleted points in previous post)

@sjacobino
Copy link

sjacobino commented Aug 27, 2021

Report from last month:

In the process of connecting the SuperApp with EBSI.

V1 api is implemented in the code but EBSI has already moved on to V2. V2 has turned several REST APIs into libraries to be used locally. Mobile libraries are not yet available, so I have implemented a CLI in TypeScript with the available EBSI api with some key functionalities (including getting access tokens to write) to the public test environment.
Working tree: https://github.com/sjacobino/trustchain-superapp/tree/ebsi

Roadmap for translation between IG-SSI and EBSI is in the works including working on the translation code.
See notes: https://drive.google.com/drive/folders/1OBEOV7G1Pb1ZbakTTg6Y42Vu1K_uX-ha?usp=sharing

Probably 1 more week to work on translating between IG-SSI attestations/presentation to EBSI Verifiable Credential/Presentation. But because mobile libraries are not available, it will not be possible to test in-app.

So likely to shelf this part for the time being and start on Data Vault.

@sjacobino
Copy link

sjacobino commented Aug 30, 2021

EBSI docs, api and libraries currently not in sync. Conflicting information on the different platforms which is making it impossible to make a working connection.

E.g.

Screen Shot 2021-08-30 at 08 55 41

So let's fix that:

Screen Shot 2021-08-30 at 08 56 03

Discrepancy in information, in this case the parameters of a DidAuthResponseCall.

Sample code on NPM site:
https://www.npmjs.com/package/@cef-ebsi/did-auth

Create Auth Response did-auth_0_0_12

Sample code on EBSI Doc:
https://ec.europa.eu/cefdigital/wiki/display/EBSIDOC/DID+Authentication+Library

Screen Shot 2021-08-30 at 13 54 30

Function definition in DIDAuth.ts
Screen Shot 2021-08-30 at 14 10 45

  • Session token
  • DiD identity
  • Verifiable Authorisation (Long term access)
  • FAIL - access token (Short term access)
Status EBSI v1 EBSI v2
Read access ✔️ ✔️
Write access ✔️

@sjacobino
Copy link

sjacobino commented Aug 30, 2021

@synctext
Copy link
Member Author

synctext commented Aug 30, 2021

Personal Data Vault (brainstorm thesis direction):

@sjacobino
Copy link

@sjacobino
Copy link

@synctext
Copy link
Member Author

synctext commented Jul 15, 2022

Mental note: https://ec.europa.eu/digital-building-blocks/wikis/display/EBSIDOC/Security+track+summary
Solid EBSI security docs
Digital decade of Europe, ambition level and governance: https://futurium.ec.europa.eu/sites/default/files/2021-11/Slides%20for%20Futurium%20Launch%20event%2017-11-21.pdf

Digital Decade vision: Empower all European citizens and
businesses to seize the benefits of a human-centred, sustainable
and prosperous digital future in a global context.

@sjacobino
Copy link

EBSI conformance update: Conformance program has changed slightly. But I found this open source SSI kit that passed the conformance test. This is bittersweet because it seems it has been developed in parallel with us, but it's more feature complete and mature than what I have. Should be able to plug it right in. https://github.com/walt-id/waltid-ssikit

@synctext
Copy link
Member Author

synctext commented Aug 1, 2022

Any update for your master thesis?
(btw Walt-ID smells like DiD-based bloatware, not IPv8 with lightning fast zero-knowledge proofs)

@sjacobino
Copy link

@sjacobino
Copy link

Still not EBSI conformant 😢 Whole process has changed and integrating with Walt id was a headache. Not necessarily bloatware as it able to parse complex credentials that I was not able to implement. And code is forked so unnecessary stuff can be removed

@synctext
Copy link
Member Author

synctext commented Aug 15, 2022

Comment on 4-page thesis draft:

  • Replace bullets in first chapter with main message. No research sub-questions. Replace with contribution of this work: "How can we give user back control of their own identity and their data?"
  • Way too specific: TrustVault builds upon the concept of personal data Pods first proposed. Replace entire paragraph.
  • no more details in introduction than: give back control. Just one sentence with details on the ID & data vault.
  • Intro political/activism message like: Our Internet-deployed proof-of-concept proven the viability of our work. We show that the European Commission EBSI initiative is viable. It is possible to re-take ownership of your digital identity and data. We offer the initial foundation for long-enduring Big Tech alternatives. This master thesis contributes a cardinal part for a European digital future without natural monopolies. It replaces the for-profit infrastructure of Big Tech with a public, transparent, non-profit and open source alternative.
  • "1. Introduction" {less activism like}: Our goal is to design a more vibrant and competitive ecosystem of digital products. Many digital markets are winner-takes-all natural monopolies [REF NEEDED]. By creating an open architecture with sovereignty as a first principle we counter monopoly ourcomes. Our self-sovereign approach ensures several competing, non-cooperating services which are interoperable with each other by virtue of building their services on top of the same open architecture and open source protocol. inspired here. More positivism: our openness-by-design ecoystem has enhanced innovation capacity, provides permissionless innovation, competitiveness, and fairness.
  • Related work becomes "5. Related work": move after "4. Implementation and Evaluation" section. Essential requirement: post .APK here.
  • Methodology: replace with "3. System Architecture and design". Focus as much on SSI as you do (later) on data sovereignty. Our key scientific breakthrough is data sharing without any cloud, without any intermediary, and full privacy. We utilise a unique peer-to-peer overlay between wallets. This zero-server solution ensures digital sovereignty for participants. This peer-to-peer architecture is difficult to realise, as the wallet needs to implement both the traditional client and also server functionality.
  • "2. Problem description". Opening line suggestion: 46 years after the invention of public key cryptography we still lack a good solution for citizens to manage their own digital existence.. Cryptography is often discussed, not yet deployed on a massive scale. How to manage your own private keys is an unsolved problem. No infrastructure exists to securely share encrypted data with your friends and family. The idea of public key cryptography was first presented by Martin Hellman, Ralph Merkle, and Whitfield Diffie at Stanford University in 1976_. Public Key infrastructure has failed us 🤕 Scientists are obsessive with post-quantum crypto. Billions of users rely on Big Tech monopolies to store their data in the cloud. Some of this data is deeply personal, such as the only copy of new born children photos. Users voluntarily give up control and ownership of their data. Own your own data. Technological Sovereignty. Local-first movement. Alternative to cloud monopoly. Outsource system maintenance, in exchange for advertisement
  • "4. Implementation and Evaluation": screenshots of global operation (ID&data) {4-5 screenshots MAX.}. wallet-to-wallet. Fine-grained control. Show live sharing of a photo without any Big Tech. Pure zero-server architecture. (offline sharing used to work, great content also)

Did a quick review of Walt ID code (non-Android Kotlin, Apache-2.0 license) :
image

@sjacobino
Copy link

@synctext
Copy link
Member Author

synctext commented Aug 22, 2022

Comments:

  • \footnote{this work is facilitated and sponsored by the Dutch government, specifically "The National Office for Identity Data (RvIG)"}
  • No link Big Tech Bad, SSI mentioning, and EBSI
  • more clarity in the introduction, high impact, EBSI is not a small tech thingie: Digital identity for all Europeans is coming. "In September 2020, Ursula von der Leyen, President of the European Commission, revealed plans for a re-vamp of the system: eIDAS 2.0. At its centre will be new digital identity wallet..) Any EU citizen or company will be able to request one (although it will remain voluntary for citizens)." and REF: https://ec.europa.eu/info/strategy/priorities-2019-2024/europe-fit-digital-age/european-digital-identity_en
  • MISSING is "2. Problem description". Opening line suggestion: (see above)
  • Architecture: way too detailed opening line and first section: "TrustVault is a component of the the TrustChain Super App
    and uses the IPv8 protocol for peer-2-peer communication." We first need to explain the European selected 'digital ID wallet' approach. For instance: This work expands the architecture of the European digital ID wallet. We mature this concept in general, added fine-grained access control, and a functional data vault.
  • "E. Tamper-proof access logs" add bit more clearly: "design"
  • "V. CONCLUSION AND FUTURE WORK": opening line needs to get back to the intro, problem description, and leave the reader with a feel-good moment: you fixed the world (of SSI). Like: 'Big Tech fully controls your digital identity and data. By building on the European Commission digital ID wallet architecture we present an alternative. We show the feasibility of this Big Tech alternative with control and ownership returned to the users themselves. Trustchain ... superapp.... Finally, we note that this ongoing work needs more effort. The fight for Internet control and user data is still ongoing.
  • "IMPLEMENTATION AND EVALUATION" how to visualise all the work you did?

Status of code:

  • Session token
  • DiD identity
  • Verifiable Authorisation (Long term access)
  • FAIL - access token (Short term access)
Status EBSI v1 EBSI v2
Read access ✔️ ✔️
Write access ✔️

Figure X depicts the functions implemented from scratch for the EBSI wallet on Android, as the first known open source implementation.

@sjacobino
Copy link

sjacobino commented Aug 30, 2022

And here it is. The final version! TrustVault_MSc_Thesis___TU_Delft-10.pdf

@synctext
Copy link
Member Author

synctext commented Aug 30, 2022

Review:

  • "extend the Security, Control and Portability properties of SSI", no caps here
  • You can easily see who currently has access to certain data. Additionally you can see who accessed certain data. "We then discuss the design for a tamper-proof access log." Our approach guarantees the integrity of these access logs.
  • Figures 4 - 7 are too small. Do not leave so much white space. Fill.
  • "Figures 4, 6 and 7 shows screenshots"
    • missing 5, missing punctuation
    • missing context: ..."shows screenshots" of our app for world domination and world peace....
  • INTRO: The societal value of the work we present here is within the same order of magnitude as the European Digital Identity Wallet with an estimated value in the public tender of 26 Million Euro.
  • conclusion: Alternative for Big Tech platforms are a new emerging research topic. We present a unique first operational system which build upon the upcoming European identity wallet. Compared to related work such as Solid, we do not require users to explicitly understand data management issues, remove system management burdens, and do not needs any management of personal data providers. Therefore, our work represents the first realistic citizen data vault and identity wallet solution. ...fine-grained access control...
  • Replace " DV " with data vault everywhere. adds clarity.
  • New master thesis format is similar to bachelor thesis format with merely 1 page of front-matter, see example
  • also: https://repository.tudelft.nl/islandora/object/uuid%3Ad61cc5f6-4af8-49e8-9ee8-9171cacec449?collection=education

@sjacobino
Copy link

sjacobino commented Aug 30, 2022

Already uploaded. Overlooked Replace " DV " with data vault everywhere. adds clarity.

@sjacobino
Copy link

sjacobino commented Aug 31, 2022

@synctext
Copy link
Member Author

synctext commented Aug 31, 2022

{quick first round feedback} first presentation comment: 58 slides is too much slides for available time. Prune some tutorial-level material. Focus on the science part. What is your related work? Citations towards scientific literature in several slides??

@sjacobino
Copy link

Some of the slides are duplicates to reveal info bit by bit. Working on related work slides.

@sjacobino
Copy link

Tutorial-level will be quick

TrustVault Presentation-2.pdf

@synctext
Copy link
Member Author

Great content! Remove empty slides with just 1 line of content --> merge
Lots of slides, then aim for 40 minutes of presentation and dont rush through the material. Explain clearly a& calmy. Looking forward..!

@synctext
Copy link
Member Author

synctext commented Aug 31, 2022

brainstorm/ideas for evaluation section:

  • performance analysis
    • measure time for credential verification, creation time, and write to Trustchain, etc.
    • measuring CPU usage
    • measure data traffic
    • Conclusion???? crypto == cheap, networking == expensive
  • performance breakdown
    • all detailed steps when providing access to your personal data
    • measure required time per task/step
  • EBSI permissions? read/write speed measurements; 1 Byte block; 1k, 10k,100k, 1 MByte blobs, 10 MByte, etc.

Missing from thesis: linking science with society (usage) == technology acceptance model. Only Big Tech realised usable systems for identity and personal data storage. Many architectures and technologies are proposed by academics, lack usability, simplistic academic thoughts, no industrial-quality realisation, and validation of assumptions outside the lab. For each of the system in the literature we depict the maturity of their work on a 5-star rating. With 1-star for only presenting an idea and 5-stars for evaluating a fully implemented system and making multiple iterations of improvements. Our screenshot of the Solid related work depicts the level of maturity of this work.
After trying for 45 years we made little progress. Analysis to add: https://link.springer.com/content/pdf/10.1007/11824633_8.pdf

Current code branch in superapp: Tribler/trustchain-superapp@master...sjacobino:trustchain-superapp:ebsi-conformance

Example SSI evaluation from Quinten paper
image

Next sprint: new .PDF 🚀

@synctext
Copy link
Member Author

synctext commented Sep 7, 2022

Raw measurements from paper above. example: "Measurements re-used with permission from [1]"
measurements.zip

@sjacobino
Copy link

ctr-cbc-decryption
ctr-cbc-encryption
transfer_latnecy

@synctext
Copy link
Member Author

synctext commented Sep 15, 2022

  • Not as much progress as hoped for in 2 weeks
  • experiment with 7-10 data points for a connecting line! (please plot a MByte per second speed with 100-ish points)
  • two screens in 1 photo + official travel document with covered personal details == experimental setup OR screenshots of 1 side in green-on-black cmdline ADB output. Example

  • process this experiment into storyline of master thesis, before moving to next thing.
  • No new experiment or new measurement. Just put this into thesis first!
  • Credential experiment: create 1 Byte credential, to Jumbo-credential of 10 MByte or just try 1 GByte to blow up stress test EBSI (schema with user parameter). Dream outcome is non-linear performance degradation and crash.
  • Write a bit of information about the code you wrote. Table of functions you implemented with LoC or use a fancy analysis tool or something. No call graph please in 15 days.

@sjacobino
Copy link

sjacobino commented Sep 22, 2022

  • Experimental setup with performance analysis done.
  • CPU usage measurements left out, not that interesting.
  • EBSI stress test not that interesting. API requests capped at 1MB. linear response time up to that point.

Still todo:

  • Information about the code (today)
  • Comparison with related work (ongoing)
  • Go over design choices and clarify where needed

Latest version:
TrustVault_MSc_Thesis___TU_Delft-4.pdf

@synctext
Copy link
Member Author

synctext commented Sep 22, 2022

  • introduction explains too much. Keep it high level and make 3 research contributions visible with 3 bullets.
  • "fined-grained AC without TTPs like distributed ABE schemes" bad style!
  • "EBSI can be the connecting piece to the societal infrastructure for identity." add more certainty: by 31Dec 2024 this will go into production and become usable for each and every EU citizen.
  • "Fig. 2. TrustVault Architecture." you solve all GDPR issues!! You store everything with the user and avoid all central data processing and requirement for a privacy officer. Its all under the users control and GDPR-compliant. This architecture is meticiously designed to provide wallet-to-wallet communication, avoid cloud-infrastructure and therefore offer GDPR-compliance by design.
  • Figure 2: take more space, too tiny
  • Figure 8,9: waaaay too tiny. 1 figure full columnwidth
  • Figure 8: time (s), input data size (MiB)
  • No text or reference to "Figure 8" ?
  • "figure 10" -> Figure 10
  • "NUMBER OF VERIFICATIONS AND DATA OVERHEAD PER REQUEST.", something about your test setup or experiment parameters?
  • "a session token adds at least 370B to a request" , bytes?
  • "210kB/s", "250MB", bad style, MiB and KiB/s ?
  • "File transfer Time (200kB) single requester", ??
  • " 220kB file is 780 milliseconds.", explain the story behind this magic number. We strive for sub-second performance, tests by Bambacht reveil that 220KiB should do the job usually,, something, bla bla.
  • brainstorm for 1 additional possible experiment: latency breakdown for verification of credential: random_seed() 12.3 ms, itterate_SBox() 8.1 ms, etc. in a graph. ? After latency our final experiment further investigates the cryptographic primitive. By opening this black box we show the most costly functions in terms of latency. The purpose of this experiment is to provide directions for future work to further minimise latency.
  • Related work example with big table
  • other inspiration: https://arxiv.org/pdf/1404.4818.pdf
    image
    image

@synctext
Copy link
Member Author

btw Please post your thesis online in IEEE-like format (without TUDelft cover): https://arxiv.org/a/pouwelse_j_1.html

@sjacobino
Copy link

sjacobino commented Jan 20, 2023

Thesis LaTex files: mkrmvqdmdzyjdtmpdqcxmyvgchwrkjmz.zip

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

3 participants