Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor : cors 설정 yml로 관리하도록 변경 #237

Merged
merged 1 commit into from
Oct 20, 2024
Merged

Conversation

Astin01
Copy link
Contributor

@Astin01 Astin01 commented Oct 18, 2024

📝작업 내용

corsproperties 클래스를 통해 cors 설정 yml파일로부터 주입받아서 설정할 수 있도록 수정

#️⃣연관된 이슈

#236

@Astin01 Astin01 added this to the v1.2.0 milestone Oct 18, 2024
@Astin01 Astin01 self-assigned this Oct 18, 2024
@Astin01 Astin01 linked an issue Oct 18, 2024 that may be closed by this pull request
Copy link
Member

@hyeonjaez hyeonjaez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

어떤 기능인지 좀 더 상세하게 작성해주세요!

@Astin01
Copy link
Contributor Author

Astin01 commented Oct 19, 2024

어떤 기능인지 좀 더 상세하게 작성해주세요!

기존에 cors 관리를 하드 코딩으로 하고 있었는데 yml 파일로 관리할 수 있도록 바꿨습니다.
다만, 이때 넣어야 하는 값들이 여러개라서 corsproperties 클래스를 만들었습니다.
구체적으로는 corsproperties에 yml 값들을 넣고 꺼내서 사용하는 식으로 로직을 구성했습니다

Copy link
Member

@hyeonjaez hyeonjaez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다

@Astin01 Astin01 merged commit f18daf9 into develop Oct 20, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor : cors 설정 yml 파일로 하도록 변경
2 participants