Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make .mako the default for Mako templates (instead of .mak) #10

Open
pedersen opened this issue Sep 24, 2012 · 9 comments
Open

Make .mako the default for Mako templates (instead of .mak) #10

pedersen opened this issue Sep 24, 2012 · 9 comments

Comments

@pedersen
Copy link
Member

This issue existed in Trac. The original can be viewed at http://trac.turbogears.org/ticket/2323

This issue existed on SourceForge. The original can be viewed at https://sourceforge.net/p/turbogears2/tickets/65

@pedersen
Copy link
Member Author

Original Author: pedersen, Original Timestamp: 2011-03-29 02:08:47.739000

Original Body: For historical reason we have been using .mak for mako template extension this is weird as noone does so. TG should use .mako like everyone else.

Also See ML thread ( http://groups.google.com/group/turbogears-trunk/browse_thread/thread/8f7321c5eca942f9 )


12/01/09 18:58:00 changed by seedifferently

Is this still planned for 2.1?

@pedersen
Copy link
Member Author

Original Author: pedersen, Original Timestamp: 2011-06-13 00:59:36.963000

Original Body: - milestone: 2.2.0 --> 2.1.2

@pedersen
Copy link
Member Author

Original Author: pedersen, Original Timestamp: 2011-08-20 03:48:57.619000

Original Body: - milestone: 2.1.2 --> 2.1.3

@pedersen
Copy link
Member Author

Original Author: pedersen, Original Timestamp: 2011-09-22 02:59:25.746000

Original Body: - milestone: 2.1.3 --> 2.1.4

@pedersen
Copy link
Member Author

Original Author: mengu, Original Timestamp: 2011-09-30 23:06:26.511000

Original Body: i wanted to do this and i have managed that. however there are three things should be done.

  1. generated .mak templates should be renamed as .mako. (done)
  2. .mak lookup in tg/render.py and tg/dottednames/mako_lookup should be changed as .mako. (done as well)
  3. tw.forms and sprox generated .mak templates should be renamed as .mako. (not done)

if you guys wish, i can send a pull request for the first two.

@pedersen
Copy link
Member Author

Original Author: pedersen, Original Timestamp: 2011-10-03 02:36:08.630000

Original Body: I'd happily merge, provided that all the tests are still passing. One request, though: Did you replace support for .mak with .mako? Or did you make TG support both?

Since we have developers who have deployed with .mak, we have to support both options, so that their upgrade path is as easy as possible. If you've already got that, send in a pull request (either on SF or github), and I'll verify the tests and merge it in.

Thank you for doing this work.

@pedersen
Copy link
Member Author

Original Author: *anonymous, Original Timestamp: 2011-10-03 18:18:56.278000

Original Body: i can change it to support both .mak and .mako.

unfortunately the tests are not passing because sprox and tw.forms are looking for .mak extension whereas the templates are .mako.

@pedersen
Copy link
Member Author

Original Author: pedersen, Original Timestamp: 2011-11-25 22:03:14.927000

Original Body: - version: 2.1.0 --> 2.1.3

  • milestone: 2.1.4 --> 2.2.0

@pedersen
Copy link
Member Author

Original Author: pedersen, Original Timestamp: 2012-08-24 01:41:44.937000

Original Body: - version: 2.1.3 --> 2.1.5

  • milestone: 2.2.0 --> 2.3.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant