Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TA comments on milestone 3 [First Pass] #28

Open
hsmohammed opened this issue Dec 11, 2019 · 0 comments
Open

TA comments on milestone 3 [First Pass] #28

hsmohammed opened this issue Dec 11, 2019 · 0 comments

Comments

@hsmohammed
Copy link

Hello,

Thanks for your milestone 3 submission. Everything looks good except for some issues I am listing below,

  • You have to provide a teamwork contract for project 2 and put a link to it in the readme.
  • In your proposal you are mixing the app purpose with its applications. Try to think about the general aim and goal of your app when writing the purpose part.
  • When doing a pull request try to summarize the tasks that you changed in the pull request description.
  • It is a good idea to provide a sketch for the DashR app.
  • It is always a good idea to provide a good and concise description of your app at the beginning of the app page.

I may give you more detailed feedback on Friday. Ensure that you commit often.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant