Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✏️ [TASK]: Add Ansible molecule setup for all roles in the collection #13

Closed
3 tasks done
p-j-smith opened this issue Dec 13, 2023 · 1 comment
Closed
3 tasks done

✏️ [TASK]: Add Ansible molecule setup for all roles in the collection #13

p-j-smith opened this issue Dec 13, 2023 · 1 comment
Assignees
@drmatthews @p-j-smith

Comments

@p-j-smith
Copy link
Contributor

p-j-smith commented Dec 13, 2023 •
edited
Loading

Task Description

Currently, in CI we only run molecule on a few of the roles:

ansible-collection-infra/tests/molecule/resources/converge.yml

Lines 7 to 17 in f350806

- role: mirsg.infrastructure.provision
tags: provision
- role: mirsg.infrastructure.install_python
tags: python
- role: mirsg.infrastructure.firewalld
tags: firewalld
- role: mirsg.infrastructure.postgresql
tags: postgresql

We should set add molecule configurations for the remaining roles. This will require:

  • updating the role README to reflect it is now part of a Collection rather than a standalone Role (remove the Requirements, Dependencies, License, and Author Information sections as these are now all in the README for the Collection instead)

  • add the role to tests/molecule/resources/converge.yml (adding a tag that can be used to selectively run the role)

  • add any preparation steps needed to tests/molecule/resources/prepare.yml

  • add any verify steps to tests/molecule/resources/verify.yml

  • add a workflow to run molecule converge on the role whenever it changes (see existing role workflows for examples)

For examples, see these PRs that add a molecule setup:

Related Work Items
Beta Give feedback
  1. Add molecule setup for mirsg.infrastructure.docker #91
  2. Add molecule setup for mirsg.infrastructure.nginx #50
    p-j-smith
  3. Add molecule setup for mirsg.infrastructure.tomcat #90
    p-j-smith

The roles related to monitoring might need a different molecule setup (with two servers rather than the current single-server setup)
@p-j-smith p-j-smith mentioned this issue Apr 5, 2024
Merged
p-j-smith added a commit that referenced this issue Apr 8, 2024
@p-j-smith @drmatthews
Add molecule config for Docker role (#92)
7684f11 
Fixes #91 
Part of #13 

- add molecule config for `mirsg.infrastructure.docker`
- add workflow to run tests in CI
- update README for `mirsg.infrastructure.docker` to reflect it is now
part of a collection (rather than a standalone role)

---------

Co-authored-by: Daniel Matthews <[email protected]>
@p-j-smith
Copy link
Contributor Author

closing as complete

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@drmatthews drmatthews

@p-j-smith p-j-smith

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@drmatthews @p-j-smith