Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests to make sure the container service is actually running #70

Closed
paddyroddy opened this issue Feb 9, 2024 · 1 comment · Fixed by #107
Closed

Add tests to make sure the container service is actually running #70

paddyroddy opened this issue Feb 9, 2024 · 1 comment · Fixed by #107
Labels

Comments

@paddyroddy
Copy link
Member

paddyroddy commented Feb 9, 2024

Short Description

Prior to #67, the container service wasn't actually working, but we had no idea. We could alleviate this with some kind of testing to check for a ping from the docker service, and even upload a sample image. An example of which can be seen here https://github.com/UCL-MIRSG/UCLH-MPBE-SRR-XNAT/blob/15d77eb2d203e898685f11b2cf6bf1cabed9fa46/.github/workflows/playbooks.yml#L74-L100

Acceptance Criteria

No response

Dependencies

No response

Details

No response

@p-j-smith
Copy link
Contributor

Yeah this would be a good first step. Ideally we'd have integration tests to create an XNAT project, upload some DICOM image, and run a container on them (this would also check the path translation between the web and container service is set up correctly)

@HChughtai HChughtai changed the title ✏️ [TASK]: Add tests to make sure the container service is actually running Add tests to make sure the container service is actually running Apr 21, 2024
@HChughtai HChughtai added the work label Apr 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants