Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

contribution guide #6

Open
Sohieb opened this issue Feb 24, 2019 · 5 comments
Open

contribution guide #6

Sohieb opened this issue Feb 24, 2019 · 5 comments

Comments

@Sohieb
Copy link
Member

Sohieb commented Feb 24, 2019

We still don't have any guidelines/rules for contributing to the project.
I'm going to start a new file (guidelines.md) to set the rules for contributing and for the style followed in the project.

Please comment here your ideas about this topic.

@OmarTahoun
Copy link
Member

@Sohieeb so we want to have something with the full (fork, create branch, make pull request, ...) and the whole thing or just simple guide lines?

@Sohieb
Copy link
Member Author

Sohieb commented Feb 24, 2019

the complete workflow (fork, .., pr, etc) + general guidelines like (style guide, naming, etc).

@OmarTahoun
Copy link
Member

OmarTahoun commented Feb 24, 2019

We can have some thing that goes like this (For contributing):
1: Fork the repo!
2: Clone your fork of the repo: git clone ____
3: Leave comments if you've started working on an issue, leave a comment as it helps avoid duplicate work.
4: Create a branch(whose name reflect the issue you are working on) and make your changes.
5: Run git commit and add your message describing what you have changed. If you have made changes that address an issue include the text Closes #1 (where 1 would be the issue number) to your commit message.
6: Submit Pull request - Once you have committed your changes locally and pushed them to your fork of the repo, a banner with a Compare & pull request button should appear to submit a pull request.

@moadmmh
Copy link
Member

moadmmh commented Feb 25, 2019

Let us avoid Random PR please i have been solving a lot of conflicts recently

@OmarTahoun
Copy link
Member

Sorry those were mostly my mistakes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants