Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improved retry behavior #1277

Open
jjallaire opened this issue Feb 10, 2025 · 1 comment
Open

improved retry behavior #1277

jjallaire opened this issue Feb 10, 2025 · 1 comment

Comments

@jjallaire
Copy link
Collaborator

Various suggestions from @craigwalton-dsit:

Sometimes when running evals against models which have flaky APIs which trigger their is_rate_limit() override to return True, users get confused as to why their eval seems to be "stuck" indefinitely. A few observations:

  1. Some provider implementations like google treat numerous errors as is_rate_limit (e.g. 500, 503 and 504) (source). Maybe this override would be better named is_retryable_error.

  2. AFAIK it is not that obvious to users that Inspect is busy retrying/waiting to retry failed HTTP requests. The inspect trace anomalies is helpful. It might be even more user-friendly if the "Running samples" UI somehow indicated that a sample was in a retry loop (a bit like how we show "Generating ...").

  3. The "rate limits" counter in the UI only updates for actual HTTP 429 errors (not other errors we treat as rate limits/retryable). This might well be the right behaviour, but just wanted to highlight this was one source of confusion. May be resolved by tackling 1.\

@tadamcz
Copy link
Contributor

tadamcz commented Feb 12, 2025

Previous discussion: #1174

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants