Blocked slots appear twice on mobile #2
Comments
SamGuay
changed the title
SamGuay
changed the title
|
It's because the system sets a buffer for both before and after scans, but buffers can overlap. But in that view they are shown twice. I can reproduce it on a laptop with developer tools, by mimicking a cellphone. This is a booked issue, that could be reported to the upstream repo, but not sure it would be a priority for the guy who salvaged the project. |
bpinsard
pushed a commit
that referenced
this issue
Oct 9, 2024
Got the following error: Slim Application Error The application could not run because of the following error: Details Code: 8192 Message:urlencode(): Passing null to parameter #1 ($string) of type string is deprecated File:/var/www/html/lib/Server/Url.php Line: 52 Trace: #0 [internal function]: Slim\Slim::handleErrors() #1 /var/www/html/lib/Server/Url.php(52): urlencode() #2 /var/www/html/lib/Application/Schedule/CalendarSubscriptionUrl.php(26): Url->AddQueryString() #3 /var/www/html/WebServices/Responses/ResourceResponse.php(82): CalendarSubscriptionUrl->__construct() LibreBooking#4 /var/www/html/WebServices/Responses/ResourcesResponse.php(20): ResourceResponse->__construct() LibreBooking#5 /var/www/html/WebServices/ResourcesWebService.php(65): ResourcesResponse->__construct() LibreBooking#6 [internal function]: ResourcesWebService->GetAll() LibreBooking#7 /var/www/html/lib/external/Slim/Router.php(200): call_user_func_array() LibreBooking#8 /var/www/html/lib/external/Slim/Slim.php(1218): Slim\Router->dispatch() LibreBooking#9 /var/www/html/lib/external/Slim/Middleware/Flash.php(86): Slim\Slim->call() LibreBooking#10 /var/www/html/lib/external/Slim/Middleware/MethodOverride.php(94): Slim\Middleware\Flash->call() LibreBooking#11 /var/www/html/lib/external/Slim/Middleware/PrettyExceptions.php(67): Slim\Middleware\MethodOverride->call() LibreBooking#12 /var/www/html/lib/external/Slim/Slim.php(1167): Slim\Middleware\PrettyExceptions->call() LibreBooking#13 /var/www/html/Web/Services/index.php(72): Slim\Slim->run() LibreBooking#14 {main}</pre></body></html>
bpinsard
pushed a commit
that referenced
this issue
Oct 9, 2024
When calling the `GetCategoryAttributes` API, got an error:
The application could not run because of the following error:
Details
Code: 8192
Message: explode(): Passing null to parameter #2 ($string) of type string is deprecated
File: /var/www/html/Domain/CustomAttribute.php
Line: 137
bpinsard
pushed a commit
that referenced
this issue
Oct 9, 2024
The user would see "Unknown error" on the page. With this fix they now see the correct message of "You do not have permission to access one or more of the requested resources" Had got this error in the log when the user did not have access to any resources: Uncaught exception: TypeError: implode(): Argument #1 ($array) must be of type array, string given in /var/www/librebooking/lib/Common/SmartyPage.php:907 #0 /var/www/librebooking/lib/Common/SmartyPage.php(907): implode() #1 /var/www/librebooking/tpl_c/bdc8821f0b14313eaf56b1ea126646d5b4ea5097_0.file.schedule.tpl.php(506): SmartyPage->Implode() #2 /var/www/librebooking/vendor/smarty/smarty/libs/sysplugins/smarty_template_resource_base.php(123): content_669e13d3aee330_23010540() #3 /var/www/librebooking/vendor/smarty/smarty/libs/sysplugins/smarty_template_compiled.php(114): Smarty_Template_Resource_Base->getRenderedTemplateCode() LibreBooking#4 /var/www/librebooking/vendor/smarty/smarty/libs/sysplugins/smarty_internal_template.php(217): Smarty_Template_Compiled->render() LibreBooking#5 /var/www/librebooking/vendor/smarty/smarty/libs/sysplugins/smarty_internal_templatebase.php(238): Smarty_Internal_Template->render() LibreBooking#6 /var/www/librebooking/vendor/smarty/smarty/libs/sysplugins/smarty_internal_templatebase.php(134): Smarty_Internal_TemplateBase->_execute() LibreBooking#7 /var/www/librebooking/Pages/Page.php(375): Smarty_Internal_TemplateBase->display() LibreBooking#8 /var/www/librebooking/Pages/SchedulePage.php(317): Page->Display() LibreBooking#9 /var/www/librebooking/Pages/ActionPage.php(32): SchedulePage->ProcessPageLoad() LibreBooking#10 /var/www/librebooking/Pages/SecurePage.php(171): ActionPage->PageLoad() LibreBooking#11 /var/www/librebooking/Web/schedule.php(8): SecurePageDecorator->PageLoad() LibreBooking#12 {main}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
To Reproduce
Actual behavior
Blocked slots appear twice all over the schedule except for the 7:30-8:00 slot.
Even the Mobile view on Desktop Chromium renders it completely different. Given I have a Firefox Desktop issue, I can't look at the mobile view on Desktop Firefox.
Expected behavior
The blocked slots should appear only once for each allocated time.
Screenshots
On Firefox (Mobile):
On Chromium (Mobile):
Mobile view on Chromium (Desktop)
System information
The text was updated successfully, but these errors were encountered: