Commands do not yell in #yelling

[49Indium]

Commands such as /weekisit do not yell in #yelling.

[andrewmeme]

I've decided to comb through the code for a bit. I discovered that commands that output texts calls yelling_exemptor from yelling.py. I wonder if that's blocking the bot from yelling out commands.

[49Indium]

Thanks for looking into this! I don't think that this is the issue, as yelling_exemptor just allows you to run commands with lowercase arguments. For example, /whatsdue has yelling_exemptor, so you don't get blocked when you search for whats due in csse1001 (note the lowercase). In contrast, /cowsay does not have the yelling_exemptor, so trying to run /cowsay hello will get blocked by the bot in #yelling (try it for yourself).

I don't blame you for being confused. I think the documentation for yelling_exemptor is lacking, both in the codebase and on the GitHub wiki. Given the complexity of yelling exemptor (in the sense that it is a decorator with also a wrapping function), this is a bit of a problem. I might try to write something up this weekend if no-one beats me to it.

Once again, thank you for having a look into this. If you want to have a go at making certain commands yell, I'd suggest looking haiku.py, specifically how it responds to haikus:

        if message.channel == discord.utils.get(
            self.bot.uqcs_server.channels, name=YELLING_CHANNEL_NAME
        ):
            await message.reply(f"Nice haiku:\n{haiku}".upper())
        else:
            await message.reply(f"Nice haiku:\n{haiku}")

Hopefully it should just be about going through all the interesting commands and doing something similar. Feel free to assign yourself to this issue if you want to have a crack.

[andrewj-brown]

Ah, not quite (yet another example of how the @yelling_exemptor is confusing and silly).

What it actually does is checks through every argument on the command it's attached to, and then if its a string, requires it to be UPPERCASE in the yelling channel. Effectively, ensures that someone can't /echo lower case text - they have to /echo UPPER CASE TEXT or else uqcsbot will still :disapproval: them.