Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

/dominoscoupons Should Use FrugalFeeds #204

Closed
49Indium opened this issue Jun 30, 2024 · 2 comments
Closed

/dominoscoupons Should Use FrugalFeeds #204

49Indium opened this issue Jun 30, 2024 · 2 comments
Assignees
Labels
enhancement update an existing command or cog for some new functionality good first issue Good for newcomers

Comments

@49Indium
Copy link
Member

As brought up by lucid8426 on discord, the /dominoscoupons command provides discounts that may not work. Potentially we should also include FrigralFeeds coupons.

One way to do this would be to add an optional argument for the source. I'm unsure what should happen by default: either just selecting one of the sources or trying to combine them. Ideally we would have some way to test if the coupons work, but I'm unsure if that is achievable and isn't required.

Note that we should probably still keep https://www.couponese.com/store/dominos.com.au/ in some form, as a good back-up as some of the coupons still work.

@49Indium 49Indium added enhancement update an existing command or cog for some new functionality good first issue Good for newcomers labels Jun 30, 2024
@tj-dodd
Copy link
Contributor

tj-dodd commented Jun 30, 2024

I've made decent progress on this issue. The user is now able to specify whether they want a list of codes from FrugalFeeds or Couponese through an optional argument, and by default the user is provided with a combined list. Right now the combined list is a random selection of discount codes (as you end up with a pretty big list), and I'm thinking of implementing a button the user can press to refresh the combined list - although what I've got might work well enough as is.

@49Indium 49Indium assigned 49Indium and tj-dodd and unassigned 49Indium Jun 30, 2024
tj-dodd referenced this issue in tj-dodd/uqcsbot-discord Jun 30, 2024
49Indium pushed a commit that referenced this issue Jul 5, 2024
#205)

* Give user option to choose between FrugalFeeds or Couponese when generating list of coupons.

* Implement requested changes

* Formatting

* Hinting fixes, FrugalFeeds compatability, hyperlinks

* Implement second wave of requested changes

* Implement third wave of changes
@49Indium
Copy link
Member Author

Completed with #205

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement update an existing command or cog for some new functionality good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants