Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

POE - pull page-scope features out of the kanban component #779

Open
KMnOFour opened this issue May 25, 2021 · 0 comments
Open

POE - pull page-scope features out of the kanban component #779

KMnOFour opened this issue May 25, 2021 · 0 comments

Comments

@KMnOFour
Copy link
Contributor

KMnOFour commented May 25, 2021

Describe the issue
The POE page contains the Kanban component, which is correct, but Kanban contains structure that belongs to the parent. It needs refactoring to better align with the separation of concerns between pages and components.

The general rules are that page components:

  • handle route requests (have a path defined in App.js)
  • determine the basic page layout and placement of components
  • contain the page Title, SidenavContainer, and Table components

Anything in the components folder must be contained by a parent page inside the parent's Main component, and should be structured so that different pages can share it without accidentally nesting duplicate sidenavs, page titles, or other page structures.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants