Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Country and Carrier lookup data errors #786

Open
KMnOFour opened this issue May 27, 2021 · 0 comments
Open

Country and Carrier lookup data errors #786

KMnOFour opened this issue May 27, 2021 · 0 comments
Assignees
Labels
4 - Done bug 🐞 Something isn't working database Requires a db script or rebuild

Comments

@KMnOFour
Copy link
Contributor

KMnOFour commented May 27, 2021

Describe the bug
Two problems.

Issue 1

Several carriers have no country assigned. After researching, the issue is that two sources were used for the airport and country datasets, and there were discrepancies in the naming conventions used for several countries. The airport dataset tends to use the informal standard naming convention where the country dataset uses the formal one, but in other cases either dataset might refer to an old name rather than the current one. Examples:

Airport country name Country country name
South Korea Korea, Republic of
Congo (Brazzaville) Congo, Republic of
Burma Myanmar

These values need to match for the airport lookup tables to be build with the correct ISO3 codes from the Country table or some Airports won't have a country code.

lookupDataBugs

Issue 2

Several country codes are incorrect or missing. Countries comprising the former Netherlands Antilles (1954 to 2010) need to be added and updated to reflect their new statuses. The flags were previously corrected in another PR.

To test:

  1. All carriers in the lookup editor should have a country code assigned (sort by country to see nulls)
  2. The following country codes in code editor > Country should exist: CUW, BES, SXM
@KMnOFour KMnOFour added the bug 🐞 Something isn't working label May 27, 2021
@KMnOFour KMnOFour self-assigned this May 27, 2021
@KMnOFour KMnOFour added database Requires a db script or rebuild 4 - Done and removed 3 - Review labels Jun 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4 - Done bug 🐞 Something isn't working database Requires a db script or rebuild
Projects
None yet
Development

No branches or pull requests

1 participant