Skip to content
This repository has been archived by the owner on Jun 2, 2023. It is now read-only.

add seg_tave_water to PRMS outputs at NHD resolution #69

Open
janetrbarclay opened this issue May 19, 2023 · 6 comments
Open

add seg_tave_water to PRMS outputs at NHD resolution #69

janetrbarclay opened this issue May 19, 2023 · 6 comments

Comments

@janetrbarclay
Copy link
Collaborator

To be able to pretrain at the NHD resolution, we need to have seg_tave_water added to the sntemp outputs that are compiled at the NHD resolution (what becomes nhdv2_inputs_io.zarr)

@lekoenig
Copy link
Collaborator

OK, gotcha! Should we retain all of the dynamic PRMS-SNTemp variables, or just stick with seginc_potet and seg_tave_water?

#> "seg_rain"            "seg_tave_air"        "seg_tave_water"      "seg_outflow"         "seg_tave_gw"        
#> "seg_tave_sroff"      "seg_tave_ss"         "seg_tave_upstream"   "seg_upstream_inflow" "seginc_gwflow"       
#> "seginc_potet"       "seginc_sroff"        "seginc_ssflow"       "seginc_swrad"        "seg_humid"          
#> "seg_shade"           "seg_ccov"           "seg_width"

@janetrbarclay
Copy link
Collaborator Author

Do we have the other dynamic ones that we currently use as river-dl inputs? (seg_rain, seg_tave_air, seginc_potet, seginc_swrad, seg_width) If not, it's worth keeping those.

@lekoenig
Copy link
Collaborator

Do we have the other dynamic ones that we currently use as river-dl inputs? (seg_rain, seg_tave_air, seginc_potet, seginc_swrad, seg_width) If not, it's worth keeping those.

No, we currently only retain seginc_potet but we can save and include all of these in the zarr data store.

@janetrbarclay
Copy link
Collaborator Author

I think maybe we're talking about different zarr's? Here's the current contents of the one I'm looking at:
image

@lekoenig
Copy link
Collaborator

This is admittedly pretty confusing and I had to remind myself that 1) we're currently only pulling seginc_potet from the dynamic PRMS-SNTemp drivers; and 2) the other variables you show are actually coming from gridmet, but we renamed them here to match the PRMS-SNTemp variable naming scheme. I'm not sure what our original justification was for matching the names, but we could certainly change that on the data-prep side of things to avoid confusion down the line.

@lekoenig
Copy link
Collaborator

I think to add seg_tave_water to the NHD-resolution outputs we would make the assumption that those water temperatures apply to all COMIDs along the PRMS/NHM river segment (like we do with seg_potet). Does that sound OK, at least as a starting point?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants