Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow users to provide the node-selector, toleration and node-selector-template #505

Open
waveywaves opened this issue Feb 28, 2024 · 2 comments

Comments

@waveywaves
Copy link
Member

waveywaves commented Feb 28, 2024

Tell us about your request

Make it possible for users to mention the node-selector template necessary to install their new uffizzi installation

uffizzi install --node-selector-template gvisor

the above will be translated to a spec for all uffizziclusters created

spec:
  nodeSelectorTemplate: gvisor

The above spec will be picked up by the Uffizzi Cluster Operator and the correct nodeselctor and tolerations spec will be given to the Workloads.

If the nodeselectortemplate flag is not given, the CLI should install . So that users can easily install Uffizzi on minikube. All clusters provided will then be vanilla k3s by default.

Which service(s) is this request for?
cli, app, controller

Tell us about the problem you're trying to solve. What are you trying to do, and why is it hard?
Installing and creating clusters on minikube/k3d

Describe the solution you'd like
Mentioned in the request

related to #503

@axisofentropy
Copy link
Member

This is fine, just change provider to node-selector and change gke to gvisor. Don't bother with vanilla, just leave null as the default.

@moklidia moklidia self-assigned this Mar 1, 2024
@waveywaves
Copy link
Member Author

updating this issue with new changes about nodeselector and tolerations

@waveywaves waveywaves changed the title Allow users to provide the kubernetes provider they would be running Uffizzi on Allow users to provide the node-selector and tolerations for they would be running Uffizzi on Mar 13, 2024
@waveywaves waveywaves changed the title Allow users to provide the node-selector and tolerations for they would be running Uffizzi on Allow users to provide the node-selector, toleration and node-selector-template Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Development

No branches or pull requests

3 participants