Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Render invalid json when preview list #157

Open
zipofar opened this issue Sep 2, 2022 · 4 comments · Fixed by #161
Open

BUG: Render invalid json when preview list #157

zipofar opened this issue Sep 2, 2022 · 4 comments · Fixed by #161
Assignees

Comments

@zipofar
Copy link
Contributor

zipofar commented Sep 2, 2022

Render invalid json:
preview list --output=json

{
             :id => 2316,
     :created_at => "2022-09-02T01:44:57.812Z",
     :updated_at => "2022-09-02T10:57:03.616Z",
          :state => "active",
    :preview_url => "deployment-2316-make-test-22je.app.qa-gke.uffizzi.com",
       :metadata => {
        :labels => {
            :repo => "my-repo-1"
        }
    },
    :deployed_by => {
        :email => "[email protected]"
    }
}
@moklidia
Copy link
Collaborator

moklidia commented Sep 7, 2022

Also need to disable comments like this when the --output option is present:

Successful Login by Identity Token
Unauthorized. Skipping credentials action.
Unauthorized. Skipping credentials action.

the38th added a commit that referenced this issue Sep 8, 2022
@the38th the38th linked a pull request Sep 8, 2022 that will close this issue
@the38th
Copy link
Contributor

the38th commented Sep 8, 2022

for QA:
command uffizzi preview list now has flag --output which can be json or pretty-json
uffizzi preview list --output=pretty-json should display deployments in human-readable json format
uffizzi preview list --output=json should display deployments in one-string json format

@NealArw
Copy link

NealArw commented Sep 8, 2022

TESTED - OK
CLI + Platform

@NealArw
Copy link

NealArw commented Sep 8, 2022

TESTED on production - OK

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants