Add some options to CreateThumbnail to allow for some customisation o… #19419
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently the CreateThumbnail plugin writes out the form:
thumbnail begin <x>x<y>
My printer (Creality V3 KE) has a display which shows thumbnails, unfortunately it expects the headers to be formed:
png begin <x>*<y>
In addition to this, Moonraker ONLY seems to accept the first format, and not the second.
In order for thumbnails to appear both on my printer screen AND in Mainsail (which used Moonraker) I have to output each resolution twice, once for each format.
This MR adds support for toggling between:
Type of change
How Has This Been Tested?
Test 1
I created a project with the old plugin, and set some settings.
My changes didn't impact those settings, and produced the same GCODE output when re-generated
Test 2:
I set inverted the first flag, and then got the expected behaviour in the GCODE.
Test 3:
I set inverted the second flag, and then got the expected behaviour in the GCODE.
Test 4:
With the each of the four combinations of the two new flags as steps, I can get all four combinations of output shown in a CGODE file.
Test Configuration:
MacOs Sequoia
Cura5
Checklist: